Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 3010803002: Eliminate uses of fuzzy arrows in pkg/testing (fix bots). (Closed)

Created:
3 years, 3 months ago by Leaf
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Eliminate uses of fuzzy arrows in pkg/testing (fix bots). The analyzer now issues hints on uses of the deprecated behavior in which dynamic is treated as bottom in certain positions. These changes eliminate cases from pkg/testing that were relying on the deprecated behavior. TBR=ahe@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3124001cc7be50eeedbf82dee8b51c5e9dbc5d92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M pkg/testing/lib/src/chain.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/testing/lib/src/expectation.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/testing/lib/src/zone_helper.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
Leaf
3 years, 3 months ago (2017-08-30 23:16:08 UTC) #2
Leaf
Committed patchset #1 (id:1) manually as 3124001cc7be50eeedbf82dee8b51c5e9dbc5d92 (presubmit successful).
3 years, 3 months ago (2017-08-30 23:25:04 UTC) #6
Siggi Cherem (dart-lang)
3 years, 3 months ago (2017-08-30 23:36:57 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698