Issue 3010763002: Fix for ScopeBuilder[] - look into setters too. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(31)

My Issues | Starred Open | Closed | All

Issue 3010763002: Fix for ScopeBuilder[] - look into setters too. (Closed)

Created:
3 years, 3 months ago by scheglov

Modified:
3 years, 3 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix for ScopeBuilder[] - look into setters too. TBR R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7924f4c42fa6546260136ac2689f004be24c2268

Patch Set 1 #

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	pkg/front_end/lib/src/fasta/scope.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

Committed patchset #1 (id:1) manually as 7924f4c42fa6546260136ac2689f004be24c2268 (presubmit successful).

3 years, 3 months ago (2017-08-30 17:32:41 UTC) #3

Message was sent while issue was closed.

I'm not sure this is right.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698