Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2789)

Unified Diff: sdk/lib/_internal/pub/lib/src/command/build.dart

Issue 301063002: First stab at "pub run" command. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add TODO. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/command/barback.dart ('k') | sdk/lib/_internal/pub/lib/src/command/run.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/command/build.dart
diff --git a/sdk/lib/_internal/pub/lib/src/command/build.dart b/sdk/lib/_internal/pub/lib/src/command/build.dart
index d154d44e057c3b61557f42aeb1a56e7ef8ec31a9..b741f40d54090c661d8cc6b3ccb9ae7df35f3bef 100644
--- a/sdk/lib/_internal/pub/lib/src/command/build.dart
+++ b/sdk/lib/_internal/pub/lib/src/command/build.dart
@@ -27,8 +27,6 @@ class BuildCommand extends BarbackCommand {
/// The path to the application's build output directory.
String get outputDirectory => commandOptions["output"];
- BarbackMode get defaultMode => BarbackMode.RELEASE;
-
List<String> get defaultSourceDirectories => ["web"];
/// The number of files that have been built and written to disc so far.
@@ -53,9 +51,8 @@ class BuildCommand extends BarbackCommand {
// Since this server will only be hit by the transformer loader and isn't
// user-facing, just use an IPv4 address to avoid a weird bug on the
// OS X buildbots.
- return AssetEnvironment.create(entrypoint, "localhost", 0, mode,
- WatcherType.NONE, useDart2JS: true)
- .then((environment) {
+ return AssetEnvironment.create(entrypoint, mode, WatcherType.NONE,
+ useDart2JS: true).then((environment) {
// Show in-progress errors, but not results. Those get handled
// implicitly by getAllAssets().
environment.barback.errors.listen((error) {
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/command/barback.dart ('k') | sdk/lib/_internal/pub/lib/src/command/run.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698