Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: pkg/front_end/testcases/runtime_checks/covariant_generic_parameter_in_interface.dart

Issue 3010613003: Simplify annotations in runtime check tests. (Closed)
Patch Set: Address code review comment Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/testcases/runtime_checks/covariant_generic_parameter_in_interface.dart
diff --git a/pkg/front_end/testcases/runtime_checks/covariant_generic_parameter_in_interface.dart b/pkg/front_end/testcases/runtime_checks/covariant_generic_parameter_in_interface.dart
index f7aa509b0d8e45300841962132194642909e45ca..319166c4a4f789ac021d845bf812bd2754f82755 100644
--- a/pkg/front_end/testcases/runtime_checks/covariant_generic_parameter_in_interface.dart
+++ b/pkg/front_end/testcases/runtime_checks/covariant_generic_parameter_in_interface.dart
@@ -6,13 +6,14 @@
library test;
abstract class I<T> {
- void f1(T x);
- void f2(T x);
+ void f1(T /*@checkInterface=semiTyped*/ x);
+ void f2(T /*@checkInterface=semiTyped*/ x);
}
class C<U> implements I<int> {
void f1(int /*@checkFormal=semiSafe*/ x) {}
- void f2(int /*@checkFormal=semiSafe*/ x, [U /*@checkFormal=semiSafe*/ y]) {}
+ void f2(int /*@checkFormal=semiSafe*/ x,
+ [U /*@checkFormal=semiSafe*/ /*@checkInterface=semiTyped*/ y]) {}
}
void g1(C<num> c) {
@@ -20,11 +21,11 @@ void g1(C<num> c) {
}
void g2(I<num> i) {
- i.f1 /*@checkCall=interface(semiTyped:0)*/ (1.5);
+ i.f1(1.5);
}
void g3(C<num> c) {
- c.f2 /*@checkCall=interface(semiTyped:1)*/ (1, 1.5);
+ c.f2(1, 1.5);
}
void test() {

Powered by Google App Engine
This is Rietveld 408576698