Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3010543002: Rename the class "KernelReader" to "KernelLoader". (Closed)

Created:
3 years, 3 months ago by sivachandra
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org, zra, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename the class "KernelReader" to "KernelLoader". There already exists a class named "Reader" in the "kernel" namespace which reads bytes from a kernel binary. The class KernelLoader (KernelReader before this change) creates VM heap objects and populates them. R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/245be6c74c9a40c725e933a5b7cd476d238fc0ef

Patch Set 1 #

Patch Set 2 : Fix names in few places #

Total comments: 2

Patch Set 3 : Fix alphabetical order in vm_sources.gni. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -1274 lines) Patch
M runtime/vm/bootstrap.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/bootstrap_nocore.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/debugger.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/isolate_reload.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/kernel.h View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/kernel.cc View 1 chunk +22 lines, -1 line 0 comments Download
M runtime/vm/kernel_binary_flowgraph.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + runtime/vm/kernel_loader.h View 1 6 chunks +15 lines, -19 lines 0 comments Download
A + runtime/vm/kernel_loader.cc View 1 24 chunks +26 lines, -45 lines 0 comments Download
D runtime/vm/kernel_reader.h View 1 chunk +0 lines, -164 lines 0 comments Download
D runtime/vm/kernel_reader.cc View 1 chunk +0 lines, -1014 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/vm_sources.gni View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sivachandra
This is a mechanical change.
3 years, 3 months ago (2017-08-28 13:28:47 UTC) #2
Kevin Millikin (Google)
LGTM.
3 years, 3 months ago (2017-08-28 13:36:30 UTC) #3
zra
https://codereview.chromium.org/3010543002/diff/20001/runtime/vm/vm_sources.gni File runtime/vm/vm_sources.gni (right): https://codereview.chromium.org/3010543002/diff/20001/runtime/vm/vm_sources.gni#newcode297 runtime/vm/vm_sources.gni:297: "kernel_loader.h", DBC: Please keep this list alphabetized.
3 years, 3 months ago (2017-08-28 14:38:06 UTC) #5
sivachandra
Will submit tomorrow. https://codereview.chromium.org/3010543002/diff/20001/runtime/vm/vm_sources.gni File runtime/vm/vm_sources.gni (right): https://codereview.chromium.org/3010543002/diff/20001/runtime/vm/vm_sources.gni#newcode297 runtime/vm/vm_sources.gni:297: "kernel_loader.h", On 2017/08/28 14:38:06, zra wrote: ...
3 years, 3 months ago (2017-08-28 15:14:44 UTC) #6
sivachandra
3 years, 3 months ago (2017-08-29 08:59:24 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
245be6c74c9a40c725e933a5b7cd476d238fc0ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698