Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3010533002: flatten token hierarchy (Closed)

Created:
3 years, 3 months ago by danrubel
Modified:
3 years, 3 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

flatten token hierarchy This merges functionality and removes several Token classes making the Token hierarchy more compact. * merge BeginTokenWithComment into BeginToken * merge KeywordTokenWithComment into KeywordToken * merge StringTokenWithComment into StringToken * merge TokenWithComment into SimpleToken R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/2d449c870ffd9bfec18d6830f07f63d3e5a21d44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -181 lines) Patch
M pkg/analyzer/lib/src/dart/ast/token.dart View 1 chunk +1 line, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart View 4 chunks +4 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/error_token.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/scanner/scanner.dart View 7 chunks +10 lines, -11 lines 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 12 chunks +32 lines, -146 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 3 months ago (2017-08-28 03:11:39 UTC) #2
ahe
lgtm
3 years, 3 months ago (2017-08-28 11:40:05 UTC) #3
danrubel
3 years, 3 months ago (2017-08-29 12:59:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2d449c870ffd9bfec18d6830f07f63d3e5a21d44 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698