Avoid to run dart code during paused_on_exit

Avoid to run dart code during paused_on_exit

When a MessageHandler gets to the paused_on_exist state it should just handle service events.

If ports are open though, at the next message the isolate will consider itself still alive and handle any kind of request.

The MessageHandler is now checking for its paused_on_exit state and avoid to handle normal messages in that state.

Closes https://github.com/dart-lang/sdk/issues/30555

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/20066b625a723d0bca4a13afe408e9d6b1442e0e

[cbernaschina, 2017-08-26 02:16:35]

Description was changed from

==========
Make MessageHandler remember the error status

When a MessageHandler gets to the paused_on_exist state it doesn't
remember the reason why it was exiting.

If ports are open at the next message the isolate will consider itself
still alive.

The MessageHandler is now storing the status that requested its
termination.

Closes https://github.com/dart-lang/sdk/issues/30555
==========

to

==========
Make MessageHandler remember the error status

When a MessageHandler gets to the paused_on_exist state it doesn't
remember the reason why it was exiting.

If ports are open at the next message the isolate will consider itself
still alive.

The MessageHandler is now storing the status that requested its
termination.

Closes https://github.com/dart-lang/sdk/issues/30555
==========

[cbernaschina, 2017-08-26 02:16:35]

cbernaschina@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[cbernaschina, 2017-08-28 22:46:16]

Description was changed from

==========
Make MessageHandler remember the error status

When a MessageHandler gets to the paused_on_exist state it doesn't
remember the reason why it was exiting.

If ports are open at the next message the isolate will consider itself
still alive.

The MessageHandler is now storing the status that requested its
termination.

Closes https://github.com/dart-lang/sdk/issues/30555
==========

to

==========
Avoid to run dart code during paused_on_exit

When a MessageHandler gets to the paused_on_exist state it should just handle
service events.

If ports are open though, at the next message the isolate will consider itself
still alive and handle any kind of request.

The MessageHandler is now checking for its paused_on_exit state and avoid to
handle normal messages in that state.

Closes https://github.com/dart-lang/sdk/issues/30555
==========

[siva, 2017-08-28 23:11:31]

As discussed offline, I guess you would upload a new set of changes

https://codereview.chromium.org/3010503002/diff/40001/runtime/observatory/tes...
File runtime/observatory/tests/service/issue_30555_test.dart (right):

https://codereview.chromium.org/3010503002/diff/40001/runtime/observatory/tes...
runtime/observatory/tests/service/issue_30555_test.dart:1: // Copyright (c)
2015, the Dart project authors.  Please see the AUTHORS file
2017

https://codereview.chromium.org/3010503002/diff/40001/runtime/observatory/tes...
runtime/observatory/tests/service/issue_30555_test.dart:18:
port.send(receive.sendPort);
Maybe move the port send to inside the timer to make sure there are no timing
related issues which makes it possible for the "port.send(null)" command to
succeed.

https://codereview.chromium.org/3010503002/diff/40001/runtime/observatory/tes...
runtime/observatory/tests/service/issue_30555_test.dart:26: port;
Maybe remove this line as discussed offline.

https://codereview.chromium.org/3010503002/diff/40001/runtime/observatory/tes...
runtime/observatory/tests/service/issue_30555_test.dart:55: }
As discussed offline maybe make these events recorded in the debugger more
explicit instead of relying on the step number, dues to timing issues some of
the events may come out of sequence causing the test to fail or get into a weird
state.

[cbernaschina, 2017-08-28 23:21:27]

https://codereview.chromium.org/3010503002/diff/40001/runtime/observatory/tes...
File runtime/observatory/tests/service/issue_30555_test.dart (right):

https://codereview.chromium.org/3010503002/diff/40001/runtime/observatory/tes...
runtime/observatory/tests/service/issue_30555_test.dart:1: // Copyright (c)
2015, the Dart project authors.  Please see the AUTHORS file
On 2017/08/28 23:11:31, siva wrote:
> 2017

Done.

https://codereview.chromium.org/3010503002/diff/40001/runtime/observatory/tes...
runtime/observatory/tests/service/issue_30555_test.dart:18:
port.send(receive.sendPort);
On 2017/08/28 23:11:31, siva wrote:
> Maybe move the port send to inside the timer to make sure there are no timing
> related issues which makes it possible for the "port.send(null)" command to
> succeed.

The final logic is changed

https://codereview.chromium.org/3010503002/diff/40001/runtime/observatory/tes...
runtime/observatory/tests/service/issue_30555_test.dart:26: port;
On 2017/08/28 23:11:31, siva wrote:
> Maybe remove this line as discussed offline.

Done.

https://codereview.chromium.org/3010503002/diff/40001/runtime/observatory/tes...
runtime/observatory/tests/service/issue_30555_test.dart:55: }
On 2017/08/28 23:11:31, siva wrote:
> As discussed offline maybe make these events recorded in the debugger more
> explicit instead of relying on the step number, dues to timing issues some of
> the events may come out of sequence causing the test to fail or get into a
weird
> state.

Done.

[siva, 2017-08-29 01:27:31]

lgtm

[cbernaschina, 2017-08-29 18:15:06]

Description was changed from

==========
Avoid to run dart code during paused_on_exit

When a MessageHandler gets to the paused_on_exist state it should just handle
service events.

If ports are open though, at the next message the isolate will consider itself
still alive and handle any kind of request.

The MessageHandler is now checking for its paused_on_exit state and avoid to
handle normal messages in that state.

Closes https://github.com/dart-lang/sdk/issues/30555
==========

to

==========
Avoid to run dart code during paused_on_exit

When a MessageHandler gets to the paused_on_exist state it should just handle
service events.

If ports are open though, at the next message the isolate will consider itself
still alive and handle any kind of request.

The MessageHandler is now checking for its paused_on_exit state and avoid to
handle normal messages in that state.

Closes https://github.com/dart-lang/sdk/issues/30555

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/20066b625a723d0bca4a13afe408e9d6b1442e0e
==========

[cbernaschina, 2017-08-29 18:15:08]

Committed patchset #9 (id:160001) manually as
20066b625a723d0bca4a13afe408e9d6b1442e0e (presubmit successful).