Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 3010483002: Add tests demonstrating bugs #30547 and #30552. (Closed)

Created:
3 years, 3 months ago by Paul Berry
Modified:
3 years, 3 months ago
Reviewers:
Leaf, Jennifer Messerly
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Mark interface classes as abstract #

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 3 months ago (2017-08-25 23:35:25 UTC) #2
Jennifer Messerly
lgtm https://codereview.chromium.org/3010483002/diff/1/tests/language_2/multiple_interface_inheritance_test.dart File tests/language_2/multiple_interface_inheritance_test.dart (right): https://codereview.chromium.org/3010483002/diff/1/tests/language_2/multiple_interface_inheritance_test.dart#newcode19 tests/language_2/multiple_interface_inheritance_test.dart:19: abstract class E implements I2, I1 {} oh ...
3 years, 3 months ago (2017-08-26 00:24:17 UTC) #3
Paul Berry
https://codereview.chromium.org/3010483002/diff/1/tests/language_2/multiple_interface_inheritance_test.dart File tests/language_2/multiple_interface_inheritance_test.dart (right): https://codereview.chromium.org/3010483002/diff/1/tests/language_2/multiple_interface_inheritance_test.dart#newcode5 tests/language_2/multiple_interface_inheritance_test.dart:5: class I1 { Whoops, I forgot to mark I1 ...
3 years, 3 months ago (2017-08-26 14:53:45 UTC) #4
Paul Berry
3 years, 3 months ago (2017-08-26 15:00:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1cadaf4b80f00c586a4ee1f96b6a31d9dbce66d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698