chrome/browser/extensions/gtalk_extension_browsertest.cc - Issue 301033004: replaced the string 'chrome-extensions://' with constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/gtalk_extension_browsertest.cc

Issue 301033004: replaced the string 'chrome-extensions://' with constants (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed yet another style issue Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_crash_recovery_browsertest.cc ('k') | chrome/browser/extensions/window_open_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/gtalk_extension_browsertest.cc

diff --git a/chrome/browser/extensions/gtalk_extension_browsertest.cc b/chrome/browser/extensions/gtalk_extension_browsertest.cc

index 8217b48c144929036a1ede3a5fcadac6b95e3b53..88024e7b7e201c93e9713a142b290845a3dff540 100644

--- a/chrome/browser/extensions/gtalk_extension_browsertest.cc

+++ b/chrome/browser/extensions/gtalk_extension_browsertest.cc

@@ -14,10 +14,12 @@

#include "content/public/browser/render_process_host.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/common/url_constants.h"

#include "content/public/test/browser_test_utils.h"

#include "extensions/browser/extension_host.h"

#include "extensions/browser/extension_system.h"

#include "extensions/browser/process_manager.h"

+#include "extensions/common/constants.h"

using content::RenderViewHost;

using content::WebContents;

@@ -50,7 +52,9 @@ class GtalkExtensionTest : public ExtensionBrowserTest {

}

std::string GetViewerUrl() {

- return "chrome-extension://" + GetInstalledExtensionId() + "/viewer.html";

+ return std::string(extensions::kExtensionScheme) +

+ content::kStandardSchemeSeparator +

Yoyo Zhou 2014/05/30 15:12:02 Line continuations should be 4 spaces. Please run

+ GetInstalledExtensionId() + "/viewer.html";

}

std::vector<RenderViewHost*> GetMatchingViews(const std::string& url_query) {