chrome/browser/chromeos/extensions/input_view_browsertest.cc - Issue 301033004: replaced the string 'chrome-extensions://' with constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/input_view_browsertest.cc

Issue 301033004: replaced the string 'chrome-extensions://' with constants (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Same patch, sent last one to wrong email Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/extensions/input_view_browsertest.cc

diff --git a/chrome/browser/chromeos/extensions/input_view_browsertest.cc b/chrome/browser/chromeos/extensions/input_view_browsertest.cc

index ef4196e344d500332f5dc38421ca668af5196fb9..fd69dfa4cf457aa4dff857ef8f1da392e1a51f3b 100644

--- a/chrome/browser/chromeos/extensions/input_view_browsertest.cc

+++ b/chrome/browser/chromeos/extensions/input_view_browsertest.cc

@@ -16,6 +16,7 @@

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/site_instance.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/common/url_constants.h"

#include "content/public/test/browser_test_utils.h"

#include "extensions/common/constants.h"

#include "extensions/common/extension.h"

@@ -39,7 +40,8 @@ struct InputViewConfig : public VirtualKeyboardBrowserTestConfig {

base_framework_ = kBaseKeyboardTestFramework;

extension_id_ = id;

test_dir_ = kInputViewTestDir;

- url_ = "chrome-extension://" + id + "/inputview.html?id=" + layout;

+ url_ = std::string(extensions::kExtensionScheme) +

+ content::kStandardSchemeSeparator + id + "/inputview.html?id=" + layout;

Lei Zhang 2014/05/29 05:21:24 For line continuations, it's 4 space indentation.

}

};

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_crash_recovery_browsertest.cc » ('j') | extensions/common/csp_validator.cc » ('J')