Issue 301033004: replaced the string 'chrome-extensions://' with constants

Issue 301033004: replaced the string 'chrome-extensions://' with constants (Closed)

Created:
6 years, 6 months ago by ivandavid

Modified:
6 years, 6 months ago

Reviewers:
Lei Zhang, Yoyo Zhou

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

replaced the string 'chrome-extensions://' with constants R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274077

Patch Set 1 #

Patch Set 2 : Same patch, sent last one to wrong email #

Total comments: 2

Patch Set 3 : Fixed style issues #

Patch Set 4 : Fixed yet another style issue #

Total comments: 1

Patch Set 5 : Ran git cl format on my changes #

Patch Set 6 : Style issue fix, bad git cl format output #

Patch Set 7 : Removed whitespace before a newline #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -12 lines)			Patch
M	chrome/browser/chromeos/extensions/input_view_browsertest.cc	View	1 2 3 4 5 6	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_crash_recovery_browsertest.cc	View	1 2 3 4 5	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/gtalk_extension_browsertest.cc	View	1 2 3 4 5	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/window_open_apitest.cc	View	1 2 3 4 5	4 chunks	+13 lines, -6 lines	0 comments	Download
M	extensions/common/csp_validator.cc	View	1 2 3 4 5	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 15 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

yoz: can you look at extensions/ ? https://codereview.chromium.org/301033004/diff/20001/chrome/browser/chromeos/extensions/input_view_browsertest.cc File chrome/browser/chromeos/extensions/input_view_browsertest.cc (right): https://codereview.chromium.org/301033004/diff/20001/chrome/browser/chromeos/extensions/input_view_browsertest.cc#newcode44 chrome/browser/chromeos/extensions/input_view_browsertest.cc:44: content::kStandardSchemeSeparator + ...

6 years, 6 months ago (2014-05-29 05:21:24 UTC) #2

Yoyo Zhou

https://codereview.chromium.org/301033004/diff/60001/chrome/browser/extensions/gtalk_extension_browsertest.cc File chrome/browser/extensions/gtalk_extension_browsertest.cc (right): https://codereview.chromium.org/301033004/diff/60001/chrome/browser/extensions/gtalk_extension_browsertest.cc#newcode56 chrome/browser/extensions/gtalk_extension_browsertest.cc:56: content::kStandardSchemeSeparator + Line continuations should be 4 spaces. Please ...

6 years, 6 months ago (2014-05-30 15:12:02 UTC) #6

ivandavid

I think I finally fixed the style issues. I ran git cl format and it ...

6 years, 6 months ago (2014-05-30 23:59:05 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivandavid@chromium.org/301033004/90001

6 years, 6 months ago (2014-05-31 00:13:52 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivandavid@chromium.org/301033004/110001

6 years, 6 months ago (2014-05-31 00:46:27 UTC) #13

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...

6 years, 6 months ago (2014-05-31 05:52:52 UTC) #14

Message was sent while issue was closed.

Change committed as 274077

Expand Messages | Collapse Messages