Pepper: Manifest ID cleanup.

Pepper: Manifest ID cleanup.

This removes a bunch of code for managing manifest IDs. Any given instance can
only have one "Json Manifest", as parsed from user-supplied NMF data. Helper
processes (llc and ld) have no corresponding NMF, but do make IRT
open_resource() calls, which eventually manifest in a call to
ManifestResolveKey.

This code should be quite a bit easier to read now, and makes the relationship
between manifest data and instances clearer.

BUG=239656
R=dmichael@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273535

[dmichael (off chromium), 2014-05-29 16:10:18]

lgtm, nice

https://codereview.chromium.org/301013002/diff/60001/components/nacl/renderer...
File components/nacl/renderer/ppb_nacl_private_impl.cc (right):

https://codereview.chromium.org/301013002/diff/60001/components/nacl/renderer...
components/nacl/renderer/ppb_nacl_private_impl.cc:1000: int32_t
CreateJsonManifest(PP_Instance instance,
You don't seem to use the return value anymore, can you remove it?

If you do need it, it might make sense to change to PP_Instance.

https://codereview.chromium.org/301013002/diff/60001/components/nacl/renderer...
components/nacl/renderer/ppb_nacl_private_impl.cc:1057: PP_Bool helper_process,
nit: is_helper_process?

[teravest, 2014-05-29 16:14:02]

https://codereview.chromium.org/301013002/diff/60001/components/nacl/renderer...
File components/nacl/renderer/ppb_nacl_private_impl.cc (right):

https://codereview.chromium.org/301013002/diff/60001/components/nacl/renderer...
components/nacl/renderer/ppb_nacl_private_impl.cc:1000: int32_t
CreateJsonManifest(PP_Instance instance,
On 2014/05/29 16:10:18, dmichael wrote:
> You don't seem to use the return value anymore, can you remove it?
> 
> If you do need it, it might make sense to change to PP_Instance.

I changed this to use bool and cleaned up the error reporting when
CreateJsonManifest fails.

https://codereview.chromium.org/301013002/diff/60001/components/nacl/renderer...
components/nacl/renderer/ppb_nacl_private_impl.cc:1057: PP_Bool helper_process,
On 2014/05/29 16:10:18, dmichael wrote:
> nit: is_helper_process?

Done.

[teravest, 2014-05-29 16:14:05]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-05-29 16:15:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/teravest@chromium.org/301013002/80001

[teravest, 2014-05-29 17:09:32]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-05-29 17:10:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/teravest@chromium.org/301013002/100001

[teravest, 2014-05-29 19:11:23]

Committed patchset #3 manually as r273535 (presubmit successful).