Issue 3010037: Add the actual data being read to the OnBytesRead callback, take two....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3010037: Add the actual data being read to the OnBytesRead callback, take two.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by bmcquade1

Modified:
4 years ago

Reviewers:
eroman

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Add the actual data being read to the OnBytesRead callback, take two. This change was originally committed as http://src.chromium.org/viewvc/chrome?view=rev&revision=53178 then rolled back as http://src.chromium.org/viewvc/chrome?view=rev&revision=53416 due to a breakage in FLAKY_UnknownSize download test. FLAKY_UnknownSize depended on code with a bug that was exposed by this change. That bug has since been fixed and committed as http://src.chromium.org/viewvc/chrome?view=rev&revision=53876 So this change is ready for another round of review. It has not changed at all since being committed. Contributed by: bmcquade@google.com BUG=48192 TEST=Added new unit tests, ran net_unittests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54448 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55224

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+316 lines, -35 lines)			Patch
M	chrome/browser/chromeos/cros/network_library.cc	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/task_manager.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/task_manager.cc	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/net.gyp	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/url_request/url_request_job.h	View	1 2 3 4	3 chunks	+19 lines, -5 lines	0 comments	Download
M	net/url_request/url_request_job.cc	View	1 2 3 4	9 chunks	+47 lines, -19 lines	0 comments	Download
M	net/url_request/url_request_job_tracker.h	View	1 2 3 4	3 chunks	+9 lines, -5 lines	0 comments	Download
M	net/url_request/url_request_job_tracker.cc	View	1 2 3 4	2 chunks	+3 lines, -2 lines	0 comments	Download
A	net/url_request/url_request_job_tracker_unittest.cc	View		1 chunk	+232 lines, -0 lines	0 comments	Download

Trybot results: linux win linux_valgrind mac linux_chromeos

Total messages: 2 (0 generated)

LGTM