Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 3010036: Merge 53471 - Fix regression that stopped properly restoring focus to tab con... (Closed)

Created:
10 years, 4 months ago by dmazzoni
Modified:
9 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 53471 - Fix regression that stopped properly restoring focus to tab contents. The bug in r51262 was that native_tab_contents_container_win overrides RequestFocus, so it can't be *reliably* focused just using SetFocus. This is a simple, straightforward fix that should be merged for M6. Afterwards, I think a better solution for the dev channel would be to get rid of the hacky RequestFocus overrides and add a View::HasNativeFocus method so that FocusManager can tell when it thinks a view already has focus, but the native focus might need to be set again. Thoughts? BUG=48917 BUG=49061 TEST=none Review URL: http://codereview.chromium.org/3013023 TBR=dmazzoni@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53835

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M views/focus/focus_manager.cc View 1 chunk +16 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dmazzoni
10 years, 4 months ago (2010-07-27 20:54:44 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698