Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: tools/buildtools/update.py

Issue 3010023002: Reland: [infra] Roll clang toolchain forward (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/buildtools/update.py
diff --git a/tools/buildtools/update.py b/tools/buildtools/update.py
index 2f9b4b8a8b1aa591d02bbd503c3cc53e773bf902..7f229de078e47a3708659239046bf33ff454ff4b 100755
--- a/tools/buildtools/update.py
+++ b/tools/buildtools/update.py
@@ -14,7 +14,6 @@ THIS_DIR = os.path.abspath(os.path.dirname(__file__))
DART_ROOT = os.path.abspath(os.path.join(THIS_DIR, '..', '..'))
BUILDTOOLS = os.path.join(DART_ROOT, 'buildtools')
TOOLS_BUILDTOOLS = os.path.join(DART_ROOT, 'tools', 'buildtools')
-TOOLCHAIN = os.path.join(BUILDTOOLS, 'toolchain')
sys.path.insert(0, os.path.join(DART_ROOT, 'tools'))
import find_depot_tools
@@ -24,7 +23,7 @@ DEPOT_PATH = find_depot_tools.add_depot_tools_to_path()
def Update():
path = os.path.join(BUILDTOOLS, 'update.sh')
- command = ['/bin/bash', path, '--toolchain', '--gn']
+ command = ['/bin/bash', path, '--clang', '--gn']
return subprocess.call(command, cwd=DART_ROOT)
@@ -74,17 +73,19 @@ def UpdateClangFormatOnWindows():
def CopyClangFormat():
if sys.platform == 'darwin':
platform = 'darwin'
- subdir = 'mac'
+ tools = 'mac'
+ toolchain = 'mac-x64'
elif sys.platform.startswith('linux'):
platform = 'linux'
- subdir = 'linux64'
+ tools = 'linux64'
+ toolchain = 'linux-x64'
else:
print 'Unknown platform: ' + sys.platform
return 1
clang_format = os.path.join(
- TOOLCHAIN, 'clang+llvm-x86_64-' + platform, 'bin', 'clang-format')
- dest = os.path.join(BUILDTOOLS, subdir, 'clang-format')
+ BUILDTOOLS, toolchain, 'clang', 'bin', 'clang-format')
+ dest = os.path.join(BUILDTOOLS, tools, 'clang-format')
shutil.copy2(clang_format, dest)
return 0
« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698