Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 3010023002: Reland: [infra] Roll clang toolchain forward (Closed)

Created:
3 years, 3 months ago by zra
Modified:
3 years, 3 months ago
Reviewers:
Bill Hesse, rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland: [infra] Roll clang toolchain forward Build spuriously worked after initial roll due to stale files hanging around longer than they should have. This CL relands and updates (hopefully) all the necessary paths. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d1b542f8cd8e9475722a2bb0f5bf4e70f5de3479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -26 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 1 chunk +2 lines, -11 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/buildtools/update.py View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 3 months ago (2017-09-01 16:09:13 UTC) #2
rmacnak
lgtm
3 years, 3 months ago (2017-09-01 17:23:45 UTC) #3
zra
3 years, 3 months ago (2017-09-01 18:15:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1b542f8cd8e9475722a2bb0f5bf4e70f5de3479 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698