Store actual Reference(s) for additional exports.

Store actual Reference(s) for additional exports.

R=johnniwinther@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/b460a25459fa261fac1c4c548bcf43c4e23a897f

[ahe, 2017-09-01 11:35:37]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, scheglov@google.com

[ahe, 2017-09-01 11:35:37]

Notice that the VM changes have already been reviewed.

The first patch set is what Konstantin originally wrote, the second patch set is
my attempt at keeping support for serializing ambiguous exports and
void/dynamic.

Notice that reexporting void and dynamic is probably wrong, but it corresponds
to the current behavior of the Dart VM, and I'd like to defer this until we've
switched the VM to use the shared front-end.

[Johnni Winther, 2017-09-01 12:32:32]

lgtm

https://codereview.chromium.org/3009953003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart (right):

https://codereview.chromium.org/3009953003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart:55: Map<String,
String> additionalExports;
Rename this to [unserializableExports] to avoid confusion with the field on
Library.

[ahe, 2017-09-01 14:05:39]

https://codereview.chromium.org/3009953003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart (right):

https://codereview.chromium.org/3009953003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart:55: Map<String,
String> additionalExports;
On 2017/09/01 12:32:32, Johnni Winther wrote:
> Rename this to [unserializableExports] to avoid confusion with the field on
> Library.

Done.

https://codereview.chromium.org/3009953003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/source_library_builder.dart (right):

https://codereview.chromium.org/3009953003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/source_library_builder.dart:542:
target.additionalExports.add(member.target.reference);
I had to move this to kernel_library_builder.dart, which highlights again that
Konstantin is right about that the hierarchy is too complicated.

[scheglov, 2017-09-01 14:10:57]

lgtm

[ahe, 2017-09-01 14:30:51]

Description was changed from

==========
Store actual Reference(s) for additional exports.
==========

to

==========
Store actual Reference(s) for additional exports.

R=johnniwinther@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b460a25459fa261fac1c4c548bcf43c4e23a897f
==========

[ahe, 2017-09-01 14:30:52]

Committed patchset #2 (id:20001) manually as
b460a25459fa261fac1c4c548bcf43c4e23a897f (presubmit successful).