Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 3009933002: Resynthesize references to type parameters in default expressions from Kernel. (Closed)

Created:
3 years, 3 months ago by scheglov
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resynthesize references to type parameters in default expressions from Kernel. Update the related tests to take into account the fact that front-end infers type arguments, but the summaries linker does not. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b617cde77885efe82e0a4afa9d3cbcdb54b344bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -38 lines) Patch
M pkg/analyzer/lib/src/kernel/resynthesize.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 11 chunks +85 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 3 months ago (2017-08-31 19:10:01 UTC) #1
Brian Wilkerson
lgtm
3 years, 3 months ago (2017-08-31 19:22:37 UTC) #2
scheglov
3 years, 3 months ago (2017-08-31 19:37:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b617cde77885efe82e0a4afa9d3cbcdb54b344bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698