Pass in `this` as a free variable to the closure class

tests/language_2/language_2_dart2js.status

 # Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 # Sections in this file should contain "$compiler == dart2js".
 
 # dart2js does not implement the Dart 2.0 static type errors yet.
 [ $compiler == dart2js ]
 abstract_beats_arguments_test: MissingCompileTimeError
 abstract_exact_selector_test/01: MissingCompileTimeError
@@ skipping 378 matching lines @@
 function_type/function_type86_test: RuntimeError # Issue 30476
 function_type/function_type87_test: RuntimeError # Issue 30476
 function_type/function_type88_test: RuntimeError # Issue 30476
 function_type/function_type89_test: RuntimeError # Issue 30476
 function_type/function_type8_test: RuntimeError # Issue 30476
 function_type/function_type90_test: RuntimeError # Issue 30476
 function_type/function_type96_test: RuntimeError # Issue 30476
 function_type/function_type9_test: RuntimeError # Issue 30476
 
 [ $compiler == dart2js && $dart2js_with_kernel && $host_checked ]
+abstract_exact_selector_test/none: Crash # Assertion failure: Missing scope info for j:getter(Iterable.iterator).
 abstract_exact_selector_test/none: Pass
-generic_methods_local_variable_declaration_test: Pass
-abstract_exact_selector_test/none: Crash # Assertion failure: Missing scope info for j:getter(Iterable.iterator).
 abstract_getter_test/01: Crash # Assertion failure: Missing scope info for j:getter(Foo.i).
 abstract_method_test: Crash # Assertion failure: Missing scope info for j:getter(A.length).
 abstract_object_method_test: Crash # Assertion failure: Missing scope info for j:method(B.==).
 abstract_override_adds_optional_args_concrete_subclass_test: Crash # Assertion failure: Missing scope info for j:method(B.foo).
 abstract_override_adds_optional_args_concrete_test: Crash # Assertion failure: Missing scope info for j:method(B.foo).
 abstract_override_adds_optional_args_test: Crash # Assertion failure: Missing scope info for j:method(B.foo).
 assert_message_test: Crash # Assertion failure: Missing scope info for j:getter(Iterable.iterator).
 assert_trailing_comma_test/none: CompileTimeError
 assertion_initializer_const_error2_test/cc02: Crash # Unsupported operation: Unexpected initializer #lib1::C::cc02 (Constructor)
 assertion_initializer_const_error2_test/none: CompileTimeError
@@ skipping 92 matching lines @@
 bound_closure_equality_test: Crash # Assertion failure: Missing scope info for j:getter(SetMixin.length).
 bound_closure_primitives_test: Crash # Assertion failure: Missing scope info for j:getter(Iterable.iterator).
 branch_canonicalization_test: RuntimeError
 break_test: Crash # RangeError (index): Invalid value: Valid value range is empty: 0
 call_closurization_test: RuntimeError
 call_function_apply_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (parameter(JsLinkedHashMap.addAll#key), parameter(JsLinkedHashMap.addAll#value), local(JsLinkedHashMap.addAll#)) for j:closure_call(JsLinkedHashMap_addAll_closure.call).
 call_operator_test: RuntimeError
 call_test: RuntimeError
 call_through_getter_test/01: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (parameter(B.g3#x), parameter(B.g3#y), parameter(B.g3#z), local(B.g3#)) for j:closure_call(B_g3_closure.call).
 call_through_getter_test/02: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (parameter(B.g3#x), parameter(B.g3#y), parameter(B.g3#z), local(B.g3#)) for j:closure_call(B_g3_closure.call).
-call_through_getter_test/none: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (parameter(B.g3#x), parameter(B.g3#y), parameter(B.g3#z), local(B.g3#)) for j:closure_call(B_g3_closure.call).
 call_with_no_such_method_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (parameter(JsLinkedHashMap.addAll#key), parameter(JsLinkedHashMap.addAll#value), local(JsLinkedHashMap.addAll#)) for j:closure_call(JsLinkedHashMap_addAll_closure.call).
 canonical_const2_test: RuntimeError
 canonical_const_test: Crash # type 'InterfaceType' is not a subtype of type 'ResolutionInterfaceType' of 'type1' where
 cast_test/none: RuntimeError
 cha_deopt1_test: CompileTimeError
 cha_deopt2_test: CompileTimeError
 cha_deopt3_test: CompileTimeError
 class_cycle_test/02: MissingCompileTimeError
 class_cycle_test/03: MissingCompileTimeError
-class_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(Sub.closureRef#)) for j:closure_call(Sub_closureRef_closure.call).
 classes_static_method_clash_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (parameter(JsLinkedHashMap.addAll#key), parameter(JsLinkedHashMap.addAll#value), local(JsLinkedHashMap.addAll#)) for j:closure_call(JsLinkedHashMap_addAll_closure.call).
-closure6_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(A.foo#)) for j:closure_call(A_foo_closure.call).
 closure_cycles_test: Crash # Assertion failure: Missing scope info for j:getter(Iterable.iterator).
 closure_in_constructor_test: Crash # type 'JClosureClass' is not a subtype of type 'ClosureClassElement' of 'closureClass' where
 closure_in_initializer2_test: RuntimeError
 closure_in_initializer_test: Crash # Assertion failure: Cannot find value parameter(A.#a) in (parameter(C.#a), BoxLocal(_box_0), parameter(C.#a), BoxLocal(_box_0)) for j:constructor(C.).
 closure_parameter_types_test: RuntimeError
 closure_self_reference_test: Crash # 'file:*/pkg/compiler/lib/src/ssa/nodes.dart': Failed assertion: line 641 pos 12: 'isClosed()': is not true.
 closure_type_variable_test: Crash # NoSuchMethodError: The getter 'typeArguments' was called on null.
 closure_type_variables_test: Crash # type 'JClosureClass' is not a subtype of type 'ClosureClassElement' of 'closureClass' where
 closure_with_super_field_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(B.returnSuperInClosure#)) for j:closure_call(B_returnSuperInClosure_closure.call).
 closure_with_super_send_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (parameter(Sub.test#e), local(Sub.test#)) for j:closure_call(Sub_test_closure.call).
@@ skipping 13 matching lines @@
 generic_field_mixin6_test/none: Crash # 'file:*/pkg/compiler/lib/src/ssa/builder_kernel.dart': Failed assertion: line 342 pos 14: 'value != null': No value for field j:field(M.field2)
 generic_field_mixin_test: Crash # 'file:*/pkg/compiler/lib/src/ssa/builder_kernel.dart': Failed assertion: line 342 pos 14: 'value != null': No value for field j:field(M.field)
 generic_function_typedef_test/01: Crash # Unsupported operation: Unsupported type parameter type node S.
 generic_function_typedef_test/none: Crash # Unsupported operation: Unsupported type parameter type node S.
 generic_functions_test: Crash # Assertion failure: Missing scope info for j:method(Iterator.moveNext).
 generic_instanceof_test: Crash # type 'JClass' is not a subtype of type 'ClassElement' of 'contextClass' where
 generic_local_functions_test: Crash # Unsupported operation: Unsupported type parameter type node Y.
 generic_methods_closure_test: Crash # Unsupported operation: Unsupported type parameter type node S.
 generic_methods_generic_class_tearoff_test: Crash # Unsupported operation: Unsupported type parameter type node T.
 generic_methods_generic_function_parameter_test: Crash # Unsupported operation: Unsupported type parameter type node V.
+generic_methods_local_variable_declaration_test: Pass

[kevmoo, 2017/08/31 18:13:57]

This seems – weird. Shouldn't the previous method line just be deleted?

[Emily Fortuna, 2017/08/31 18:19:02]

short answer -- yes, that does seem weird. I'll send a follow-up CL. 

I updated this status file with Siggi's script. I think that means there's a bug
in the script. I'll talk to Siggi about it.

 generic_methods_named_parameters_test: Crash # Unsupported operation: Unsupported type parameter type node T.
 generic_methods_optional_parameters_test: Crash # Unsupported operation: Unsupported type parameter type node T.
 generic_methods_shadowing_test: Crash # Unsupported operation: Unsupported type parameter type node T.
 generic_methods_tearoff_specialization_test: Crash # Unsupported operation: Unsupported type parameter type node T.
 generic_methods_test: Crash # Assertion failure: Missing scope info for j:method(Iterator.moveNext).
 generic_methods_type_expression_test: Crash # type 'JClass' is not a subtype of type 'ClassElement' of 'contextClass' where
 generic_native_test: Crash # NoSuchMethodError: The method 'hasSubclass' was called on null.
 generic_sync_star_test: Crash # Assertion failure: Missing scope info for j:getter(Iterable.iterator).
 generic_syntax_test: Crash # NoSuchMethodError: The method 'hasSubclass' was called on null.
 generic_test: RuntimeError
 generic_typedef_test: Crash # Unsupported operation: Unsupported type parameter type node T.
 getter_override2_test/02: MissingCompileTimeError
 getter_override_test/00: MissingCompileTimeError
 getter_override_test/01: MissingCompileTimeError
 getter_override_test/02: MissingCompileTimeError
 hash_map_null_key_foreach_test: RuntimeError
 identical_closure2_test: RuntimeError
-if_null_assignment_behavior_test/01: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(C.instanceTest#)) for j:closure_call(C_instanceTest_closure.call).
-if_null_assignment_behavior_test/02: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(C.instanceTest#)) for j:closure_call(C_instanceTest_closure.call).
+abstract_override_adds_optional_args_supercall_test: Crash # Assertion failure: Missing scope info for j:method(B.foo).
+bad_constructor_test/05: MissingCompileTimeError
 if_null_assignment_behavior_test/05: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(D.derivedInstanceTest#)) for j:closure_call(D_derivedInstanceTest_closure.call).
 if_null_assignment_behavior_test/06: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(D.derivedInstanceTest#)) for j:closure_call(D_derivedInstanceTest_closure.call).
 if_null_assignment_behavior_test/12: RuntimeError
 if_null_assignment_static_test/01: RuntimeError
 if_null_assignment_static_test/03: RuntimeError
 if_null_assignment_static_test/05: RuntimeError
 many_generic_instanceof_test: Crash # type 'JClass' is not a subtype of type 'ClassElement' of 'contextClass' where
 regress_30339_test: Crash # Assertion failure: Missing scope info for j:getter(Iterable.iterator).
 type_variable_nested_test/01: Crash # NoSuchMethodError: The method 'hasSubclass' was called on null.
 type_variable_nested_test/none: Crash # NoSuchMethodError: The method 'hasSubclass' was called on null.
@@ skipping 111 matching lines @@
 bound_closure_equality_test: Crash # NoSuchMethodError: The getter 'thisLocal' was called on null.
 bound_closure_primitives_test: Crash # NoSuchMethodError: The getter 'thisLocal' was called on null.
 branch_canonicalization_test: RuntimeError
 break_test: Crash # RangeError (index): Invalid value: Valid value range is empty: 0
 call_closurization_test: RuntimeError
 call_function_apply_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (parameter(JsLinkedHashMap.addAll#key), parameter(JsLinkedHashMap.addAll#value), local(JsLinkedHashMap.addAll#)) for j:closure_call(JsLinkedHashMap_addAll_closure.call).
 call_operator_test: RuntimeError
 call_test: RuntimeError
 call_through_getter_test/01: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (parameter(B.g3#x), parameter(B.g3#y), parameter(B.g3#z), local(B.g3#)) for j:closure_call(B_g3_closure.call).
 call_through_getter_test/02: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (parameter(B.g3#x), parameter(B.g3#y), parameter(B.g3#z), local(B.g3#)) for j:closure_call(B_g3_closure.call).
-call_through_getter_test/none: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (parameter(B.g3#x), parameter(B.g3#y), parameter(B.g3#z), local(B.g3#)) for j:closure_call(B_g3_closure.call).
 call_with_no_such_method_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (parameter(JsLinkedHashMap.addAll#key), parameter(JsLinkedHashMap.addAll#value), local(JsLinkedHashMap.addAll#)) for j:closure_call(JsLinkedHashMap_addAll_closure.call).
 canonical_const2_test: RuntimeError
 canonical_const_test: Crash # NoSuchMethodError: Class 'InterfaceType' has no instance getter 'kind'.
 cast_test/none: RuntimeError
 cha_deopt1_test: CompileTimeError
 cha_deopt2_test: CompileTimeError
 cha_deopt3_test: CompileTimeError
 class_cycle_test/02: MissingCompileTimeError
 class_cycle_test/03: MissingCompileTimeError
-class_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(Sub.closureRef#)) for j:closure_call(Sub_closureRef_closure.call).
 classes_static_method_clash_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (parameter(JsLinkedHashMap.addAll#key), parameter(JsLinkedHashMap.addAll#value), local(JsLinkedHashMap.addAll#)) for j:closure_call(JsLinkedHashMap_addAll_closure.call).
-closure6_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(A.foo#)) for j:closure_call(A_foo_closure.call).
 closure_cycles_test: Crash # NoSuchMethodError: The getter 'thisLocal' was called on null.
 closure_in_constructor_test: Crash # NoSuchMethodError: Class 'JClosureClass' has no instance getter 'methodElement'.
 closure_in_initializer2_test: RuntimeError
 closure_in_initializer_test: Crash # Assertion failure: Cannot find value parameter(A.#a) in (parameter(C.#a), BoxLocal(_box_0), parameter(C.#a), BoxLocal(_box_0)) for j:constructor(C.).
 closure_parameter_types_test: RuntimeError
 closure_self_reference_test: RuntimeError
 closure_type_variable_test: Crash # NoSuchMethodError: The getter 'typeArguments' was called on null.
 closure_type_variables_test: Crash # NoSuchMethodError: Class 'JClosureClass' has no instance getter 'methodElement'.
 closure_with_super_field_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(B.returnSuperInClosure#)) for j:closure_call(B_returnSuperInClosure_closure.call).
 closure_with_super_send_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (parameter(Sub.test#e), local(Sub.test#)) for j:closure_call(Sub_test_closure.call).
@@ skipping 30 matching lines @@
 generic_sync_star_test: Crash # NoSuchMethodError: The getter 'thisLocal' was called on null.
 generic_syntax_test: Crash # NoSuchMethodError: The method 'hasSubclass' was called on null.
 generic_test: RuntimeError
 generic_typedef_test: Crash # Unsupported operation: Unsupported type parameter type node T.
 getter_override2_test/02: MissingCompileTimeError
 getter_override_test/00: MissingCompileTimeError
 getter_override_test/01: MissingCompileTimeError
 getter_override_test/02: MissingCompileTimeError
 hash_map_null_key_foreach_test: RuntimeError
 identical_closure2_test: RuntimeError
-if_null_assignment_behavior_test/01: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(C.instanceTest#)) for j:closure_call(C_instanceTest_closure.call).
-if_null_assignment_behavior_test/02: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(C.instanceTest#)) for j:closure_call(C_instanceTest_closure.call).
+abstract_override_adds_optional_args_supercall_test: Crash # NoSuchMethodError: The getter 'thisLocal' was called on null.
+bad_constructor_test/05: MissingCompileTimeError
 if_null_assignment_behavior_test/05: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(D.derivedInstanceTest#)) for j:closure_call(D_derivedInstanceTest_closure.call).
 if_null_assignment_behavior_test/06: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(D.derivedInstanceTest#)) for j:closure_call(D_derivedInstanceTest_closure.call).
 if_null_assignment_behavior_test/12: RuntimeError
 if_null_assignment_static_test/01: RuntimeError
 if_null_assignment_static_test/03: RuntimeError
 if_null_assignment_static_test/05: RuntimeError
 many_generic_instanceof_test: Crash # NoSuchMethodError: Class 'JClass' has no instance getter 'typeVariables'.
 regress_30339_test: Crash # NoSuchMethodError: The getter 'thisLocal' was called on null.
 type_variable_nested_test/01: Crash # NoSuchMethodError: The method 'hasSubclass' was called on null.
 type_variable_nested_test/none: Crash # NoSuchMethodError: The method 'hasSubclass' was called on null.
@@ skipping 71 matching lines @@
 function_type/function_type99_test: Crash # Issue 27394
 generic_function_typedef_test: Crash # Issue 27394
 generic_function_typedef_test/none: Crash # Issue 27394
 getter_setter_in_lib_test: Crash # Issue 27394
 
 [ $compiler == dart2js && $runtime == safarimobilesim ]
 call_through_getter_test: Fail, OK
 
 [ $compiler == dart2js && $minified && ! $dart2js_with_kernel ]
 generic_closure_test: Fail # Issue 12605