Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 3009873002: Add another runtime check test case. (Closed)

Created:
3 years, 3 months ago by Paul Berry
Modified:
3 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add another runtime check test case. This test case verifies correct generation of abstract forwarding stubs. Since analyzer doesn't contain logic for generating abstract forwarding stubs, the test is in "runtime_checks_new" so that it won't be checked against analyzer. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a09896216d14200fa208448e118d26c688c96411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
M pkg/front_end/testcases/ast_builder.status View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/front_end/testcases/runtime_checks_new/derived_class_typed.dart View 1 chunk +26 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/runtime_checks_new/derived_class_typed.dart.direct.expect View 1 chunk +25 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/runtime_checks_new/derived_class_typed.dart.outline.expect View 1 chunk +22 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/strong.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 3 months ago (2017-08-30 19:33:06 UTC) #2
scheglov
LGTM
3 years, 3 months ago (2017-08-30 19:36:32 UTC) #3
Paul Berry
3 years, 3 months ago (2017-08-30 20:23:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a09896216d14200fa208448e118d26c688c96411 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698