Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: pkg/compiler/README.md

Issue 3009813002: Delete dart2js_resolver and fix some typos in README (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/bin/resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/README.md
diff --git a/pkg/compiler/README.md b/pkg/compiler/README.md
index 8841b154b4913cc5cf2eae5b20216a4801e95690..e91c9399e3d9a61837010c6ad5f55efa3712f865 100644
--- a/pkg/compiler/README.md
+++ b/pkg/compiler/README.md
@@ -16,10 +16,9 @@ The compiler will operate in these general phases:
* Collect dart sources transtively
* Convert to kernel AST
- (this is will handled by invoking the front-end package)
+ (this will be handled by invoking the front-end package)
- Alternatively, the compiler can start compilation directly from a kernel
- file(s).
+ Alternatively, the compiler can start compilation directly from kernel files.
2. **model**: Create a Dart model of the program
* The kernel ASTs could be used as a model, so this might be a no-op or just
@@ -206,7 +205,7 @@ are some of the legacy terminology we have:
Dart programs, like "libraries", "classes", "methods", etc.
* **entity model**: also describes elements seen in Dart programs, but it is
- meant to be minimalistic and a super-hierarcy above the *element models*.
+ meant to be minimalistic and a super-hierarchy above the *element models*.
This is a newer addition, is an added abstraction to make it possible to
refactor our code from our old frontend to the kernel frontend.
@@ -228,7 +227,7 @@ are some of the legacy terminology we have:
### Code layout
-Here are some details of our current code layout and what's on each file. This
+Here are some details of our current code layout and what's in each file. This
list also includes some action items (labeled AI below), which are mainly
cleanup tasks that we have been discussing for a while:
@@ -242,12 +241,6 @@ revisited
AI: change how we build the SDK to launch dart2js from here, most logic might
remain inside `lib/src/dart2js.dart` for testing purposes.
-* `bin/resolver.dart`: an experimental binary we used to run the resolver and
- serializer. As we are moving to work on top of kernel this is deprecated and
- should be deleted.
-
- AI: delete this file.
-
**lib folder**: API to use dart2js as a library. This is used by our
command-line tool to launch dart2js, but also by pub to invoke dart2js as a
library during `pub-build` and `pub-serve`.
@@ -458,7 +451,7 @@ functionality is publicly exposed.
* `lib/src/compiler_new.dart`: defines the interface of these providers (see
`CompilerInput` and `CompilerOutput`).
- * `lib/src/null_compiler_output.dart`: an `CompilerOutput` that discards all
+ * `lib/src/null_compiler_output.dart`: a `CompilerOutput` that discards all
data written to it (name derives from /dev/null).
* `lib/src/source_file_provider.dart`: _TODO: add details_.
@@ -563,7 +556,7 @@ functionality is publicly exposed.
* `tool`: some helper scripts, some of these could be deleted
* `tool/perf.dart`: used by our benchmark runners to measure performance of
- some frontend pieces of dart2js. We shuld be able to delete it in the near
+ some frontend pieces of dart2js. We should be able to delete it in the near
future once the front end code is moved into `fasta`.
* `tool/perf_test.dart`: small test to ensure we don't break `perf.dart`.
« no previous file with comments | « no previous file | pkg/compiler/bin/resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698