Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 3009803002: Mark types of Constructor parameters and preserve referenced typedefs. (Closed)

Created:
3 years, 3 months ago by scheglov
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark types of Constructor parameters and preserve referenced typedefs. R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5d07433bb198c652ffd7aef100f49550680c2287

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -9 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart View 10 chunks +42 lines, -7 lines 0 comments Download
M pkg/front_end/test/src/incremental/mock_sdk.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/shaker/empty_program.dart.shaker View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/testcases/shaker/lib/lib.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/testcases/shaker/typedefs_in_types.dart View 1 chunk +3 lines, -1 line 2 comments Download
M pkg/front_end/testcases/shaker/typedefs_in_types.dart.shaker View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
scheglov
3 years, 3 months ago (2017-08-29 22:09:08 UTC) #1
Paul Berry
lgtm
3 years, 3 months ago (2017-08-29 22:13:25 UTC) #2
Siggi Cherem (dart-lang)
https://codereview.chromium.org/3009803002/diff/1/pkg/front_end/testcases/shaker/typedefs_in_types.dart File pkg/front_end/testcases/shaker/typedefs_in_types.dart (right): https://codereview.chromium.org/3009803002/diff/1/pkg/front_end/testcases/shaker/typedefs_in_types.dart#newcode8 pkg/front_end/testcases/shaker/typedefs_in_types.dart:8: foo(Typedef1<dynamic> x) => null; is there a way to ...
3 years, 3 months ago (2017-08-29 22:32:17 UTC) #3
scheglov
https://codereview.chromium.org/3009803002/diff/1/pkg/front_end/testcases/shaker/typedefs_in_types.dart File pkg/front_end/testcases/shaker/typedefs_in_types.dart (right): https://codereview.chromium.org/3009803002/diff/1/pkg/front_end/testcases/shaker/typedefs_in_types.dart#newcode8 pkg/front_end/testcases/shaker/typedefs_in_types.dart:8: foo(Typedef1<dynamic> x) => null; On 2017/08/29 22:32:17, Siggi Cherem ...
3 years, 3 months ago (2017-08-29 22:38:54 UTC) #4
Siggi Cherem (dart-lang)
lgtm - thanks
3 years, 3 months ago (2017-08-29 22:42:12 UTC) #5
scheglov
3 years, 3 months ago (2017-08-29 23:53:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5d07433bb198c652ffd7aef100f49550680c2287 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698