[observatory] Add an "ownership" analysis for the heap snapshot.

[observatory]  Add an "ownership" analysis for the heap snapshot.

An object A is said to be owned by object B if all direct references to A come from B. In particular, an object that holds unshared lists and maps will own the heap size of those lists and maps, as well as any unshared elements. We hope a table of owned sizes will be more useful than a table of shallow sizes, since the latter typically says the heap is mostly lists.

R=cbernaschina@google.com

Committed: https://github.com/dart-lang/sdk/commit/b7a0458196d73f6f6de0272f78d0d1a9547f88cf

[rmacnak, 2017-08-29 20:29:53]

Description was changed from

==========
WIP: in-degree(0) merge
==========

to

==========
[observatory]  Add an "ownership" analysis for the heap snapshot.

An object A is said to be owned by object B if all references to A come from B.
In particular, an object that holds unshared lists and maps will own the heap
size of those lists and maps, as well as any unshared elements. We hope a table
of owned sizes will be more useful than a table of shallow sizes, since the
later typically says the heap is mostly lists.
==========

[rmacnak, 2017-08-29 20:30:01]

Description was changed from

==========
[observatory]  Add an "ownership" analysis for the heap snapshot.

An object A is said to be owned by object B if all references to A come from B.
In particular, an object that holds unshared lists and maps will own the heap
size of those lists and maps, as well as any unshared elements. We hope a table
of owned sizes will be more useful than a table of shallow sizes, since the
later typically says the heap is mostly lists.
==========

to

==========
[observatory]  Add an "ownership" analysis for the heap snapshot.

An object A is said to be owned by object B if all references to A come from B.
In particular, an object that holds unshared lists and maps will own the heap
size of those lists and maps, as well as any unshared elements. We hope a table
of owned sizes will be more useful than a table of shallow sizes, since the
later typically says the heap is mostly lists.
==========

[rmacnak, 2017-08-29 20:36:29]

Description was changed from

==========
[observatory]  Add an "ownership" analysis for the heap snapshot.

An object A is said to be owned by object B if all references to A come from B.
In particular, an object that holds unshared lists and maps will own the heap
size of those lists and maps, as well as any unshared elements. We hope a table
of owned sizes will be more useful than a table of shallow sizes, since the
later typically says the heap is mostly lists.
==========

to

==========
[observatory]  Add an "ownership" analysis for the heap snapshot.

An object A is said to be owned by object B if all references to A come from B.
In particular, an object that holds unshared lists and maps will own the heap
size of those lists and maps, as well as any unshared elements. We hope a table
of owned sizes will be more useful than a table of shallow sizes, since the
latter typically says the heap is mostly lists.
==========

[rmacnak, 2017-08-29 20:36:39]

rmacnak@google.com changed reviewers:
+ asiva@google.com, cbernaschina@google.com

[cbernaschina, 2017-08-29 21:07:01]

https://codereview.chromium.org/3009743003/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/heap_snapshot.dart (right):

https://codereview.chromium.org/3009743003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/heap_snapshot.dart:303: final items =
_snapshot.ownershipClasses.toList();
The field ownershipClasses is not defined in M.HeapSnapshot

It should be added in the models/objects/heap_snapshot.dart and
mocks/objects/heap_snapshot.dart

https://codereview.chromium.org/3009743003/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart (right):

https://codereview.chromium.org/3009743003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart:285: class
OwnershipClass {
ditto

[rmacnak, 2017-08-29 23:59:34]

Also fixed overly-strict assert that initial sizes are non-zero. The stack and
root have size 0.

https://codereview.chromium.org/3009743003/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/heap_snapshot.dart (right):

https://codereview.chromium.org/3009743003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/heap_snapshot.dart:303: final items =
_snapshot.ownershipClasses.toList();
On 2017/08/29 21:07:00, cbernaschina wrote:
> The field ownershipClasses is not defined in M.HeapSnapshot
> 
> It should be added in the models/objects/heap_snapshot.dart and
> mocks/objects/heap_snapshot.dart

Done.

https://codereview.chromium.org/3009743003/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart (right):

https://codereview.chromium.org/3009743003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart:285: class
OwnershipClass {
On 2017/08/29 21:07:00, cbernaschina wrote:
> ditto

Done.

[cbernaschina, 2017-08-30 00:00:49]

lgtm

[cbernaschina, 2017-08-30 00:00:51]

lgtm

[rmacnak, 2017-08-30 16:41:11]

Description was changed from

==========
[observatory]  Add an "ownership" analysis for the heap snapshot.

An object A is said to be owned by object B if all references to A come from B.
In particular, an object that holds unshared lists and maps will own the heap
size of those lists and maps, as well as any unshared elements. We hope a table
of owned sizes will be more useful than a table of shallow sizes, since the
latter typically says the heap is mostly lists.
==========

to

==========
[observatory]  Add an "ownership" analysis for the heap snapshot.

An object A is said to be owned by object B if all direct references to A come
from B. In particular, an object that holds unshared lists and maps will own the
heap size of those lists and maps, as well as any unshared elements. We hope a
table of owned sizes will be more useful than a table of shallow sizes, since
the latter typically says the heap is mostly lists.
==========

[rmacnak, 2017-08-30 16:51:03]

Description was changed from

==========
[observatory]  Add an "ownership" analysis for the heap snapshot.

An object A is said to be owned by object B if all direct references to A come
from B. In particular, an object that holds unshared lists and maps will own the
heap size of those lists and maps, as well as any unshared elements. We hope a
table of owned sizes will be more useful than a table of shallow sizes, since
the latter typically says the heap is mostly lists.
==========

to

==========
[observatory]  Add an "ownership" analysis for the heap snapshot.

An object A is said to be owned by object B if all direct references to A come
from B. In particular, an object that holds unshared lists and maps will own the
heap size of those lists and maps, as well as any unshared elements. We hope a
table of owned sizes will be more useful than a table of shallow sizes, since
the latter typically says the heap is mostly lists.

R=cbernaschina@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b7a0458196d73f6f6de0272f78d0d1a9547f88cf
==========

[rmacnak, 2017-08-30 16:51:04]

Committed patchset #5 (id:80001) manually as
b7a0458196d73f6f6de0272f78d0d1a9547f88cf (presubmit successful).