Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 3009733002: fix how DDC finds its undefined constant (Closed)

Created:
3 years, 3 months ago by Jennifer Messerly
Modified:
3 years, 3 months ago
Reviewers:
vsm, Bill Hesse
CC:
dev-compiler+reviews_dartlang.org, Bill Hesse
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase and rebuild JS files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -64 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 3 chunks +8 lines, -6 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js View 1 4 chunks +8 lines, -4 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/closure.js View 1 4 chunks +21 lines, -15 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/destructuring.js View 1 2 chunks +12 lines, -11 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/equality_test.js View 1 22 chunks +25 lines, -19 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/es6_modules.js View 1 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/identity_test.js View 1 4 chunks +6 lines, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen_expected/node_modules.js View 1 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/script.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js View 1 9 chunks +14 lines, -6 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js.map View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen_expected/unresolved_names.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/varargs.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bill Hesse
Adding whesse to CC so I know when this lands.
3 years, 3 months ago (2017-08-29 15:07:40 UTC) #2
Jennifer Messerly
Hi Vijay can you take a look? I may TBR this so we can unblock ...
3 years, 3 months ago (2017-08-29 21:10:54 UTC) #4
vsm
lgtm
3 years, 3 months ago (2017-08-29 21:12:52 UTC) #5
Jennifer Messerly
3 years, 3 months ago (2017-08-29 21:16:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
353583fb10e630b88f326fbb3c156a6659eb3442 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698