Shut up windows build errors on new GM

Shut up windows build errors on new GM

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14941

[mtklein, 2014-05-28 22:37:15]

lgtm

[commit-bot: I haz the power, 2014-05-28 22:37:30]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/300973005/1

[commit-bot: I haz the power, 2014-05-28 22:42:38]

Change committed as 14941

[bungeman-skia, 2014-05-28 22:43:56]

I see what you did there.

https://codereview.chromium.org/300973005/diff/1/gm/blurrect.cpp
File gm/blurrect.cpp (right):

https://codereview.chromium.org/300973005/diff/1/gm/blurrect.cpp#newcode206
gm/blurrect.cpp:206: canvas->translate((SkScalar)cur_x, (SkScalar)cur_y);
You should rather use SkIntToScalar here, you dirty c style cast propagator.

[mtklein, 2014-05-28 22:48:26]

https://codereview.chromium.org/300973005/diff/1/gm/blurrect.cpp
File gm/blurrect.cpp (right):

https://codereview.chromium.org/300973005/diff/1/gm/blurrect.cpp#newcode206
gm/blurrect.cpp:206: canvas->translate((SkScalar)cur_x, (SkScalar)cur_y);
On 2014/05/28 22:43:56, bungeman1 wrote:
> You should rather use SkIntToScalar here, you dirty c style cast propagator.

I thought the consensus was that SkIntToScalar is pointless now that we're
committed it it being float or double?

[bungeman-skia, 2014-05-28 22:55:52]

On 2014/05/28 22:48:26, mtklein wrote:
> https://codereview.chromium.org/300973005/diff/1/gm/blurrect.cpp
> File gm/blurrect.cpp (right):
> 
> https://codereview.chromium.org/300973005/diff/1/gm/blurrect.cpp#newcode206
> gm/blurrect.cpp:206: canvas->translate((SkScalar)cur_x, (SkScalar)cur_y);
> On 2014/05/28 22:43:56, bungeman1 wrote:
> > You should rather use SkIntToScalar here, you dirty c style cast propagator.
> 
> I thought the consensus was that SkIntToScalar is pointless now that we're
> committed it it being float or double?

I think it's more that I don't like the bare c style cast and SkIntToScaler(...)
is nicer looking, has more meaning, and is shorter than
static_cast<Scaler>(...). Maybe it's just that I'm used to the style from habit
as well.

[mtklein, 2014-05-28 22:59:55]

> I think it's more that I don't like the bare c style cast and
SkIntToScaler(...)
> is nicer looking, has more meaning, and is shorter than
> static_cast<Scaler>(...). Maybe it's just that I'm used to the style from
habit
> as well.

Hmm.  If only we had a universal do-what-I-mean convert to SkScalar function. 
We could even just call it SkScalar, so you just write SkScalar(foo).  That'd be
nice.