Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 300973003: Add CC to the GN build, work on GPU more (Closed)

Created:
6 years, 6 months ago by brettw
Modified:
6 years, 6 months ago
Reviewers:
jamesr, piman
CC:
chromium-reviews, piman+watch_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Add CC to the GN build, work on GPU more BUG= R=jamesr@chromium.org TBR=piman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273588

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : git log' #

Total comments: 4

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1145 lines, -109 lines) Patch
M BUILD.gn View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M build/config/linux/BUILD.gn View 2 chunks +76 lines, -23 lines 0 comments Download
M build/config/linux/pkg_config.gni View 2 chunks +9 lines, -3 lines 0 comments Download
A cc/BUILD.gn View 1 2 3 4 5 1 chunk +781 lines, -0 lines 0 comments Download
M gpu/BUILD.gn View 1 chunk +113 lines, -1 line 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 2 chunks +76 lines, -29 lines 0 comments Download
A + gpu/config/BUILD.gn View 1 2 1 chunk +54 lines, -41 lines 0 comments Download
A + gpu/skia_bindings/BUILD.gn View 3 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/libXNVCtrl/BUILD.gn View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M ui/gl/BUILD.gn View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
6 years, 6 months ago (2014-05-28 23:17:36 UTC) #1
jamesr
took a look out of curiosity and cc/ lgtm, but i don't understand the gpu/ ...
6 years, 6 months ago (2014-05-28 23:24:15 UTC) #2
brettw
New snap up. https://codereview.chromium.org/300973003/diff/80001/cc/BUILD.gn File cc/BUILD.gn (right): https://codereview.chromium.org/300973003/diff/80001/cc/BUILD.gn#newcode450 cc/BUILD.gn:450: #"//gpu", TODO(GYP) Good point, fixed https://codereview.chromium.org/300973003/diff/80001/gpu/command_buffer/client/BUILD.gn ...
6 years, 6 months ago (2014-05-29 16:50:14 UTC) #3
brettw
6 years, 6 months ago (2014-05-29 20:54:30 UTC) #4
Message was sent while issue was closed. 
Committed patchset #6 manually as r273588 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698