Handle int/double literals in inference

Handle int/double literals in inference

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/a92088997ffe91a03f80dd3ee27bb0d5396dd8f8

[Johnni Winther, 2017-08-28 10:15:39]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-08-28 22:34:57]

lgtm

https://codereview.chromium.org/3009693002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/builder_kernel.dart (right):

https://codereview.chromium.org/3009693002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/builder_kernel.dart:37: SideEffects _sideEffects =
new SideEffects.empty();
nit: remove? I'm guessing you'll start using it in a follow up CL, just curious
why add it now + the ignore warning comment?

https://codereview.chromium.org/3009693002/diff/1/tests/compiler/dart2js/infe...
File tests/compiler/dart2js/inference/data/simple.dart (right):

https://codereview.chromium.org/3009693002/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/data/simple.dart:22: large();
maybe add something that doesn't fit in 32 bit as well?

[Johnni Winther, 2017-08-29 08:31:25]

https://codereview.chromium.org/3009693002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/builder_kernel.dart (right):

https://codereview.chromium.org/3009693002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/builder_kernel.dart:37: SideEffects _sideEffects =
new SideEffects.empty();
On 2017/08/28 22:34:57, Siggi Cherem (dart-lang) wrote:
> nit: remove? I'm guessing you'll start using it in a follow up CL, just
curious
> why add it now + the ignore warning comment?

It wasn't added, just moved and renamed to be private.

Removed.

https://codereview.chromium.org/3009693002/diff/1/tests/compiler/dart2js/infe...
File tests/compiler/dart2js/inference/data/simple.dart (right):

https://codereview.chromium.org/3009693002/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/data/simple.dart:22: large();
On 2017/08/28 22:34:57, Siggi Cherem (dart-lang) wrote:
> maybe add something that doesn't fit in 32 bit as well?

Done.

[Johnni Winther, 2017-08-29 08:41:36]

Description was changed from

==========
Handle int/double literals in inference
==========

to

==========
Handle int/double literals in inference

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a92088997ffe91a03f80dd3ee27bb0d5396dd8f8
==========

[Johnni Winther, 2017-08-29 08:41:38]

Committed patchset #2 (id:20001) manually as
a92088997ffe91a03f80dd3ee27bb0d5396dd8f8 (presubmit successful).