Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: tools/migration/lib/src/migrate_statuses.dart

Issue 3009653002: Don't migrate status entries under a "[ $strong ]" header. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/migration/lib/src/migrate_statuses.dart
diff --git a/tools/migration/lib/src/migrate_statuses.dart b/tools/migration/lib/src/migrate_statuses.dart
index 900cc0284ccbeb5010718ce52df82e7a2f142ef6..36c2606be459b544872ec17490603ac99ec4bb96 100644
--- a/tools/migration/lib/src/migrate_statuses.dart
+++ b/tools/migration/lib/src/migrate_statuses.dart
@@ -107,6 +107,12 @@ class EntrySet {
return false;
}
+ // The main "_strong.status" files skip lots of tests that are or were not
+ // strong mode clean. We don't want to skip those tests in 2.0 -- we want
+ // to fix them. If we're in that header, do remove the entry from the old
+ // file, but don't add it to the new one.
+ if (header == "[ \$strong ]") return true;
+
// If the condition places it directly into one file, put it there.
if (possibleFiles.length == 1) {
destination = "${toDir}_${possibleFiles.single}.status";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698