Fix for Flutter issue 11260 (https://github.com/flutter/flutter/issues/11260)

Fix for Flutter issue 11260 (https://github.com/flutter/flutter/issues/11260)
Do not rely on the udp_receive_buffer field from IsolateData as a buffer for
reading data in the recvfrom call.

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/8817846da6c4e6f74225d9dceeed7b02b072715f

[siva, 2017-08-25 20:12:40]

asiva@google.com changed reviewers:
+ zra@google.com

[zra, 2017-08-25 20:33:31]

https://codereview.chromium.org/3009643002/diff/1/runtime/bin/socket.cc
File runtime/bin/socket.cc (right):

https://codereview.chromium.org/3009643002/diff/1/runtime/bin/socket.cc#newco...
runtime/bin/socket.cc:368: intptr_t available =
SocketBase::Available(socket->fd());
const

https://codereview.chromium.org/3009643002/diff/1/runtime/bin/socket.cc#newco...
runtime/bin/socket.cc:384: intptr_t bytes_read = SocketBase::RecvFrom(
const

https://codereview.chromium.org/3009643002/diff/1/runtime/bin/socket.cc#newco...
runtime/bin/socket.cc:387: Dart_SetReturnValue(args, Dart_Null());
It looks like SocketBase:Available() can return 0. If it does we should probably
do this.

[siva, 2017-08-25 22:07:28]

https://codereview.chromium.org/3009643002/diff/1/runtime/bin/socket.cc
File runtime/bin/socket.cc (right):

https://codereview.chromium.org/3009643002/diff/1/runtime/bin/socket.cc#newco...
runtime/bin/socket.cc:368: intptr_t available =
SocketBase::Available(socket->fd());
On 2017/08/25 20:33:31, zra wrote:
> const

Done.

https://codereview.chromium.org/3009643002/diff/1/runtime/bin/socket.cc#newco...
runtime/bin/socket.cc:384: intptr_t bytes_read = SocketBase::RecvFrom(
On 2017/08/25 20:33:31, zra wrote:
> const

Done.

https://codereview.chromium.org/3009643002/diff/1/runtime/bin/socket.cc#newco...
runtime/bin/socket.cc:387: Dart_SetReturnValue(args, Dart_Null());
On 2017/08/25 20:33:31, zra wrote:
> It looks like SocketBase:Available() can return 0. If it does we should
probably
> do this.

Added a 0 check above.

[zra, 2017-08-25 22:11:14]

lgtm

[siva, 2017-08-25 22:27:00]

Description was changed from

==========
Fix for Flutter issue 11260 (https://github.com/flutter/flutter/issues/11260)
Do not rely on the udp_receive_buffer field from IsolateData as a buffer for
reading data in the recvfrom call.

BUG=
==========

to

==========
Fix for Flutter issue 11260 (https://github.com/flutter/flutter/issues/11260)
Do not rely on the udp_receive_buffer field from IsolateData as a buffer for
reading data in the recvfrom call.

BUG=
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8817846da6c4e6f74225d9dceeed7b02b072715f
==========

[siva, 2017-08-25 22:27:01]

Committed patchset #2 (id:20001) manually as
8817846da6c4e6f74225d9dceeed7b02b072715f (presubmit successful).