tools/perf/measurements/rasterize_and_record_micro.py - Issue 300963004: cc: Add message passing mechanism to micro benchmarking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/rasterize_and_record_micro.py

Issue 300963004: cc: Add message passing mechanism to micro benchmarking. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/rasterize_and_record_micro.py

diff --git a/tools/perf/measurements/rasterize_and_record_micro.py b/tools/perf/measurements/rasterize_and_record_micro.py

index d33423cd310e3cfa0d6a75ba8fda5671a70e02cc..8728d1705cd47e119e189c386dba25788c014d9b 100644

--- a/tools/perf/measurements/rasterize_and_record_micro.py

+++ b/tools/perf/measurements/rasterize_and_record_micro.py

@@ -68,7 +68,7 @@ class RasterizeAndRecordMicro(page_measurement.PageMeasurement):

tab.ExecuteJavaScript("""

window.benchmark_results = {};

window.benchmark_results.done = false;

- window.benchmark_results.scheduled =

+ window.benchmark_results.id =

chrome.gpuBenchmarking.runMicroBenchmark(

"rasterize_and_record_benchmark",

function(value) {

@@ -80,8 +80,8 @@ class RasterizeAndRecordMicro(page_measurement.PageMeasurement):

});

""")

- scheduled = tab.EvaluateJavaScript('window.benchmark_results.scheduled')

- if (not scheduled):

+ benchmark_id = tab.EvaluateJavaScript('window.benchmark_results.id')

+ if (not benchmark_id):

raise page_measurement.MeasurementFailure(

'Failed to schedule rasterize_and_record_micro')