Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: pkg/dev_compiler/tool/ddc

Issue 3009623002: fix list_test for strong mode, and fix DDC List constructors (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/tool/ddc
diff --git a/pkg/dev_compiler/tool/ddc b/pkg/dev_compiler/tool/ddc
index 0fa6f37645699ee6987da21adcf69d8420bfe6cf..5e7c492eff41a94c32b36e712ba06b3719a99b7b 100755
--- a/pkg/dev_compiler/tool/ddc
+++ b/pkg/dev_compiler/tool/ddc
@@ -21,7 +21,13 @@ pushd $LIBROOT > /dev/null
echo "
let sdk = require(\"dart_sdk\");
let main = require(\"$BASENAME\").$BASENAME.main;
- sdk._isolate_helper.startRootIsolate(main, []);" \
+ sdk.dart.ignoreWhitelistedErrors(false);
+ try {
+ sdk._isolate_helper.startRootIsolate(main, []);
+ } catch(e) {
+ console.error(e.toString(), sdk.dart.stackTrace(e).toString());
Jennifer Messerly 2017/08/25 18:08:57 This is to make sure the error stack trace prints.
+ process.exit(1);
+ }" \
> $LIBROOT/$BASENAME.run.js
-node $BASENAME.run.js
+node $BASENAME.run.js || exit 1
popd > /dev/null

Powered by Google App Engine
This is Rietveld 408576698