Serialize exports scopes.

Serialize exports scopes.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/aff5d768d79d8b3059feae250a58769dd473f5d3

[ahe, 2017-08-25 10:59:00]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, sigmund@google.com

[Johnni Winther, 2017-08-25 11:20:42]

lgtm

https://codereview.chromium.org/3009573002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart (right):

https://codereview.chromium.org/3009573002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart:150: Uri originUri =
Uri.parse(additionalExport[0]);
Test `additionalExport[0]` for `null`. Uri.parse throws otherwise.

https://codereview.chromium.org/3009573002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart:158: builder =
library.exportScopeBuilder[name];
-> library?.exportScopeBuilder[name];

https://codereview.chromium.org/3009573002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart:159: if (library !=
null) {
Remove this if statement

https://codereview.chromium.org/3009573002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/source_library_builder.dart (right):

https://codereview.chromium.org/3009573002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_library_builder.dart:527:
additionalExports.add(<String>["${parent.uri}", name]);
Add a TODO here for the absolute name problem mentioned IRL.

[ahe, 2017-08-25 11:53:14]

Johnni, thank you for catching those bugs.

As we discussed offline, I'll land the CL as it is now with a single status file
update and then immediately start working on fixing the issues you pointed out.
My motivation for doing it this way is that kernel integration in flutter is
blocked by this, and by submitting now, I can monitor the build bots before EOB.

[ahe, 2017-08-25 11:54:19]

Description was changed from

==========
Serialize exports scopes.
==========

to

==========
Serialize exports scopes.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/aff5d768d79d8b3059feae250a58769dd473f5d3
==========

[ahe, 2017-08-25 11:54:21]

Committed patchset #2 (id:20001) manually as
aff5d768d79d8b3059feae250a58769dd473f5d3 (presubmit successful).

[Siggi Cherem (dart-lang), 2017-08-25 14:30:44]

awesome, thanks for fixing this so quickly! LGTM

It would also be nice to add a unit test to kernel_generator_test.dart where we
test the modular API, to ensure resolution is working well end to end.

Similar to the second repro I wrote in Issue #30448

[Siggi Cherem (dart-lang), 2017-08-25 18:50:18]

https://codereview.chromium.org/3009573002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart (right):

https://codereview.chromium.org/3009573002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart:150: Uri originUri =
Uri.parse(additionalExport[0]);
On 2017/08/25 11:20:42, Johnni Winther wrote:
> Test `additionalExport[0]` for `null`. Uri.parse throws otherwise.

BTW - seems that flutter tools is hitting this already :(