Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Unified Diff: pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart

Issue 3009563002: Make finalize() async and await adding imports, if any. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
diff --git a/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart b/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
index e1c881a4c07f5a9f3de3ae0cad73aef3d2f3013a..356d3177fc0609c91c229ec3f61925cc178efe82 100644
--- a/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
+++ b/pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
@@ -1038,19 +1038,21 @@ class DartFileEditBuilderImpl extends FileEditBuilderImpl
}
@override
- void finalize() {
- CompilationUnitElement unitElement = unit.element;
- LibraryElement libraryElement = unitElement.library;
- CompilationUnitElement definingUnitElement =
- libraryElement.definingCompilationUnit;
- if (definingUnitElement == unitElement) {
- _addLibraryImports(libraryElement, librariesToImport);
- } else {
- (changeBuilder as DartChangeBuilder).addFileEdit(
- definingUnitElement.source.fullName, (DartFileEditBuilder builder) {
- (builder as DartFileEditBuilderImpl)
- ._addLibraryImports(libraryElement, librariesToImport);
- });
+ Future<Null> finalize() async {
+ if (librariesToImport.isNotEmpty) {
+ CompilationUnitElement unitElement = unit.element;
+ LibraryElement libraryElement = unitElement.library;
+ CompilationUnitElement definingUnitElement =
+ libraryElement.definingCompilationUnit;
+ if (definingUnitElement == unitElement) {
+ _addLibraryImports(libraryElement, librariesToImport);
+ } else {
+ await (changeBuilder as DartChangeBuilder).addFileEdit(
+ definingUnitElement.source.fullName, (DartFileEditBuilder builder) {
+ (builder as DartFileEditBuilderImpl)
+ ._addLibraryImports(libraryElement, librariesToImport);
+ });
+ }
}
}
« no previous file with comments | « pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698