Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 3009563002: Make finalize() async and await adding imports, if any. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make finalize() async and await adding imports, if any. There were two flaky tests for assists because sometimes we managed to execute adding imports before performing checks in the test. And in this case there was additional (unexpected) empty file edit for the library file (the only expected file edit was for the part). R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/dc605662936ecfa382d3a3278efa7e5df4d7bc5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart View 1 chunk +15 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 4 months ago (2017-08-25 03:57:36 UTC) #1
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-08-25 04:02:08 UTC) #2
scheglov
3 years, 4 months ago (2017-08-25 04:07:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dc605662936ecfa382d3a3278efa7e5df4d7bc5a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698