Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 3009533002: Move getElement() tests from AbstractResynthesizeTest mixin into AST resynthesizer tests. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move getElement() tests from AbstractResynthesizeTest mixin into AST resynthesizer tests. This functionality is implemented differently for Kernel. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9f36521cc502598cd88dc043e70d43516a2bb7d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -155 lines) Patch
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +105 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 3 chunks +0 lines, -106 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 3 chunks +0 lines, -47 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 4 months ago (2017-08-24 19:48:26 UTC) #1
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-08-24 21:04:57 UTC) #2
Paul Berry
lgtm
3 years, 4 months ago (2017-08-24 21:27:25 UTC) #3
scheglov
3 years, 4 months ago (2017-08-24 21:50:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9f36521cc502598cd88dc043e70d43516a2bb7d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698