Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 3009523002: [dart:io] Remove DART_IO_DISABLED (Closed)

Created:
3 years, 4 months ago by zra
Modified:
3 years, 4 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[dart:io] Remove DART_IO_DISABLED This was only used by Dartium. Committed: https://github.com/dart-lang/sdk/commit/747868f2b1609607e7616e409b7a404ccc07b4a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1000 lines) Patch
M runtime/bin/builtin_impl_sources.gni View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/bin/directory.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D runtime/bin/directory_unsupported.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M runtime/bin/eventhandler.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/eventhandler_android.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/eventhandler_fuchsia.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/eventhandler_macos.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D runtime/bin/eventhandler_unsupported.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M runtime/bin/eventhandler_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/file.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/file_system_watcher.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/file_system_watcher.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/file_system_watcher_android.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/file_system_watcher_fuchsia.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/file_system_watcher_linux.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/file_system_watcher_macos.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D runtime/bin/file_system_watcher_unsupported.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M runtime/bin/file_system_watcher_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D runtime/bin/file_unsupported.cc View 1 chunk +0 lines, -192 lines 0 comments Download
M runtime/bin/filter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/filter.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D runtime/bin/filter_unsupported.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M runtime/bin/io_impl_sources.gni View 6 chunks +0 lines, -10 lines 0 comments Download
M runtime/bin/io_service.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/io_service.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/io_service_no_ssl.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/io_service_no_ssl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D runtime/bin/io_service_unsupported.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M runtime/bin/platform.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D runtime/bin/platform_unsupported.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M runtime/bin/platform_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/process.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/process_android.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/process_fuchsia.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/process_linux.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/process_macos.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D runtime/bin/process_unsupported.cc View 1 chunk +0 lines, -97 lines 0 comments Download
M runtime/bin/process_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/root_certificates_unsupported.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/secure_socket_filter.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/secure_socket_unsupported.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/secure_socket_utils.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/security_context.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/security_context_android.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/security_context_fuchsia.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/security_context_linux.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/security_context_macos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/security_context_win.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/socket.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/socket.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/socket_android.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/socket_base.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/socket_base.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/socket_base_android.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/socket_base_fuchsia.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/socket_base_linux.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/socket_base_macos.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D runtime/bin/socket_base_unsupported.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M runtime/bin/socket_base_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/socket_fuchsia.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/socket_linux.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/socket_macos.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/socket_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/stdio.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/stdio.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/stdio_android.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/stdio_fuchsia.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/stdio_linux.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/stdio_macos.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D runtime/bin/stdio_unsupported.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M runtime/bin/stdio_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/sync_socket.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/sync_socket.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/sync_socket_android.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/sync_socket_fuchsia.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/sync_socket_linux.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/sync_socket_macos.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D runtime/bin/sync_socket_unsupported.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M runtime/bin/sync_socket_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 4 months ago (2017-08-24 18:10:11 UTC) #2
siva
STV
3 years, 4 months ago (2017-08-24 18:14:47 UTC) #3
zra
3 years, 4 months ago (2017-08-24 18:17:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
747868f2b1609607e7616e409b7a404ccc07b4a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698