Issue 3009483002: Handle assert_test without useKernelInSsa

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3009483002: Handle assert_test without useKernelInSsa (Closed)

Created:
3 years, 3 months ago by Johnni Winther

Modified:
3 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -19 lines)			Patch
	M	pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart	View		7 chunks	+9 lines, -10 lines	0 comments	Download
	M	tests/compiler/dart2js/kernel/assert_test.dart	View		2 chunks	+5 lines, -9 lines	0 comments	Download

Total messages: 5 (2 generated)

Siggi Cherem (dart-lang)

lgtm - wow - only type renames :), beautifully done.

3 years, 3 months ago (2017-08-25 00:31:26 UTC) #3

Johnni Winther

3 years, 3 months ago (2017-08-30 09:37:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8c6c2c4bfcb44eeafd3dbb5560a0cf8efefbbf7d (presubmit successful).