Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 3009473002: Stop using useKernelInSsa in compileMultiple (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -41 lines) Patch
M tests/compiler/dart2js/kernel/compiler_helper.dart View 1 2 chunks +9 lines, -41 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-24 13:41:33 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/3009473002/diff/1/tests/compiler/dart2js/kernel/compiler_helper.dart File tests/compiler/dart2js/kernel/compiler_helper.dart (right): https://codereview.chromium.org/3009473002/diff/1/tests/compiler/dart2js/kernel/compiler_helper.dart#newcode44 tests/compiler/dart2js/kernel/compiler_helper.dart:44: Compiler compiler2 = compilerFor( nit: rename compiler2 to ...
3 years, 4 months ago (2017-08-25 00:27:39 UTC) #3
Johnni Winther
https://codereview.chromium.org/3009473002/diff/1/tests/compiler/dart2js/kernel/compiler_helper.dart File tests/compiler/dart2js/kernel/compiler_helper.dart (right): https://codereview.chromium.org/3009473002/diff/1/tests/compiler/dart2js/kernel/compiler_helper.dart#newcode44 tests/compiler/dart2js/kernel/compiler_helper.dart:44: Compiler compiler2 = compilerFor( On 2017/08/25 00:27:39, Siggi Cherem ...
3 years, 3 months ago (2017-08-30 09:02:51 UTC) #4
Johnni Winther
3 years, 3 months ago (2017-08-30 09:08:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3ddcf1a190fb55c136596d1a4a82e58a85aee7b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698