Handle labelled continue statements

Handle labelled continue statements

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/69c233d8e2e0ba2a49eb79a8703533568e7ec511

[Johnni Winther, 2017-08-24 08:03:57]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Johnni Winther, 2017-08-24 12:59:04]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-08-25 00:38:50]

lgtm

https://codereview.chromium.org/3009463002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_model/locals.dart (right):

https://codereview.chromium.org/3009463002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_model/locals.dart:220: if (target.labels.isEmpty) {
nit: consider adding a helper function instead to do:

var label = _getOrCreateLabel(target, node.target);
label.isBreakTarget = true;

Then we have a single place to maintain the invariant that there is only one
label per target

[Johnni Winther, 2017-08-25 07:11:51]

https://codereview.chromium.org/3009463002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_model/locals.dart (right):

https://codereview.chromium.org/3009463002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_model/locals.dart:220: if (target.labels.isEmpty) {
On 2017/08/25 00:38:50, Siggi Cherem (dart-lang) wrote:
> nit: consider adding a helper function instead to do:
> 
> var label = _getOrCreateLabel(target, node.target);
> label.isBreakTarget = true;
> 
> Then we have a single place to maintain the invariant that there is only one
> label per target

Done.

[Johnni Winther, 2017-08-25 07:24:29]

Description was changed from

==========
Handle labelled continue statements
==========

to

==========
Handle labelled continue statements

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/69c233d8e2e0ba2a49eb79a8703533568e7ec511
==========

[Johnni Winther, 2017-08-25 07:24:31]

Committed patchset #3 (id:40001) manually as
69c233d8e2e0ba2a49eb79a8703533568e7ec511 (presubmit successful).