Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2134)

Unified Diff: Source/devtools/front_end/network/RequestHeadersView.js

Issue 300913002: DevTools: show HTTP headers of cached resources in network panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed test Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorResourceAgent.cpp ('k') | Source/devtools/front_end/networkPanel.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/network/RequestHeadersView.js
diff --git a/Source/devtools/front_end/network/RequestHeadersView.js b/Source/devtools/front_end/network/RequestHeadersView.js
index 3dfe1398a292de30b4eee643f5c4fa2b34b43c25..8ad05d967835e41aa8cdecaa6412f6c18f8acb7f 100644
--- a/Source/devtools/front_end/network/RequestHeadersView.js
+++ b/Source/devtools/front_end/network/RequestHeadersView.js
@@ -397,10 +397,13 @@ WebInspector.RequestHeadersView.prototype = {
requestMethodElement.title = this._formatHeader(WebInspector.UIString("Request Method"), this._request.requestMethod);
- var value = statusCodeFragment.createChild("div", "header-value source-code");
- value.textContent = this._request.statusCode + " " + this._request.statusText;
- if (this._request.cached)
- value.createChild("span", "status-from-cache").textContent = " " + WebInspector.UIString("(from cache)");
+ var statusTextElement = statusCodeFragment.createChild("div", "header-value source-code");
+ var statusText = this._request.statusCode + " " + this._request.statusText;
+ if (this._request.cached) {
+ statusText += " " + WebInspector.UIString("(from cache)");
+ statusTextElement.classList.add("status-from-cache");
+ }
+ statusTextElement.textContent = statusText;
statusCodeElement.title = statusCodeFragment;
}
@@ -424,16 +427,16 @@ WebInspector.RequestHeadersView.prototype = {
* @param {string} title
* @param {!Array.<!WebInspector.NetworkRequest.NameValue>} headers
* @param {!TreeElement} headersTreeElement
- * @param {boolean=} showCaution
+ * @param {boolean=} provisionalHeaders
*/
- _refreshHeaders: function(title, headers, headersTreeElement, showCaution)
+ _refreshHeaders: function(title, headers, headersTreeElement, provisionalHeaders)
{
headersTreeElement.removeChildren();
var length = headers.length;
this._refreshHeadersTitle(title, headersTreeElement, length);
- if (showCaution) {
+ if (provisionalHeaders) {
var cautionText = WebInspector.UIString("Provisional headers are shown");
var cautionFragment = document.createDocumentFragment();
cautionFragment.createChild("div", "warning-icon-small");
@@ -443,7 +446,7 @@ WebInspector.RequestHeadersView.prototype = {
headersTreeElement.appendChild(cautionTreeElement);
}
- headersTreeElement.hidden = !length && !showCaution;
+ headersTreeElement.hidden = !length && !provisionalHeaders;
for (var i = 0; i < length; ++i) {
var headerTreeElement = new TreeElement(this._formatHeader(headers[i].name, headers[i].value));
headerTreeElement.selectable = false;
« no previous file with comments | « Source/core/inspector/InspectorResourceAgent.cpp ('k') | Source/devtools/front_end/networkPanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698