Add fixes for more lints

pkg/analysis_server/test/services/correction/fix_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analysis_server/plugin/edit/fix/fix_core.dart';
 import 'package:analysis_server/plugin/edit/fix/fix_dart.dart';
 import 'package:analysis_server/src/services/correction/fix.dart';
 import 'package:analysis_server/src/services/correction/fix_internal.dart';
@@ skipping 5558 matching lines @@
 ''';
     await findLint(src, LintNames.always_require_non_null_named_parameters);
     await applyFix(DartFixKind.LINT_ADD_REQUIRED);
     verifyResult('''
 void function({@required String param}) {
   assert(param != null);
 }
 ''');
   }
 
+  test_isNotEmpty() async {
+    String src = '''
+f(c) {
+  if (/*LINT*/!c.isEmpty) {}
+}
+''';
+    await findLint(src, LintNames.prefer_is_not_empty);
+
+    await applyFix(DartFixKind.USE_IS_NOT_EMPTY);
+
+    verifyResult('''
+f(c) {
+  if (c.isNotEmpty) {}
+}
+''');
+  }
+
   test_lint_addMissingOverride_field() async {
     String src = '''
 class abstract Test {
   int get t;
 }
 class Sub extends Test {
   int /*LINT*/t = 42;
 }
 ''';
     await findLint(src, LintNames.annotate_overrides);
@@ skipping 512 matching lines @@
     verifyResult('''
 class A {
   int x;
   void foo() {
     x = 2;
   }
 }
 ''');
   }
 
-  test_removeTypeName_avoidAnnotatingWithDynamic_InsideFunctionTypedFormalParameter() async {
+  test_removeTypeAnnotation_avoidAnnotatingWithDynamic_InsideFunctionTypedFormalParameter() async {
     String src = '''
 bad(void foo(/*LINT*/dynamic x)) {
   return null;
 }
 ''';
     await findLint(src, LintNames.avoid_annotating_with_dynamic);
 
     await applyFix(DartFixKind.REMOVE_TYPE_NAME);
 
     verifyResult('''
 bad(void foo(x)) {
   return null;
 }
 ''');
   }
 
-  test_removeTypeName_avoidAnnotatingWithDynamic_NamedParameter() async {
+  test_removeTypeAnnotation_avoidAnnotatingWithDynamic_NamedParameter() async {
     String src = '''
 bad({/*LINT*/dynamic defaultValue}) {
   return null;
 }
 ''';
     await findLint(src, LintNames.avoid_annotating_with_dynamic);
 
     await applyFix(DartFixKind.REMOVE_TYPE_NAME);
 
     verifyResult('''
 bad({defaultValue}) {
   return null;
 }
 ''');
   }
 
-  test_removeTypeName_avoidAnnotatingWithDynamic_NormalParameter() async {
+  test_removeTypeAnnotation_avoidAnnotatingWithDynamic_NormalParameter() async {
     String src = '''
 bad(/*LINT*/dynamic defaultValue) {
   return null;
 }
 ''';
     await findLint(src, LintNames.avoid_annotating_with_dynamic);
 
     await applyFix(DartFixKind.REMOVE_TYPE_NAME);
 
     verifyResult('''
 bad(defaultValue) {
   return null;
 }
 ''');
   }
 
-  test_removeTypeName_avoidAnnotatingWithDynamic_OptionalParameter() async {
+  test_removeTypeAnnotation_avoidAnnotatingWithDynamic_OptionalParameter() async {
     String src = '''
 bad([/*LINT*/dynamic defaultValue]) {
   return null;
 }
 ''';
     await findLint(src, LintNames.avoid_annotating_with_dynamic);
 
     await applyFix(DartFixKind.REMOVE_TYPE_NAME);
 
     verifyResult('''
 bad([defaultValue]) {
   return null;
 }
 ''');
   }
 
-  test_removeTypeName_avoidReturnTypesOnSetters_void() async {
+  test_removeTypeAnnotation_avoidReturnTypesOnSetters_void() async {
     String src = '''
 /*LINT*/void set speed2(int ms) {}
 ''';
     await findLint(src, LintNames.avoid_return_types_on_setters);
 
     await applyFix(DartFixKind.REMOVE_TYPE_NAME);
 
     verifyResult('''
 set speed2(int ms) {}
 ''');
   }
 
-  test_removeTypeName_avoidTypesOnClosureParameters_FunctionTypedFormalParameter() async {
+  test_removeTypeAnnotation_avoidTypesOnClosureParameters_FunctionTypedFormalParameter() async {
     String src = '''
 var functionWithFunction = (/*LINT*/int f(int x)) => f(0);
 ''';
     await findLint(src, LintNames.avoid_types_on_closure_parameters);
 
     await applyFix(DartFixKind.REPLACE_WITH_IDENTIFIER);
 
     verifyResult('''
 var functionWithFunction = (f) => f(0);
 ''');
   }
 
-  test_removeTypeName_avoidTypesOnClosureParameters_NamedParameter() async {
+  test_removeTypeAnnotation_avoidTypesOnClosureParameters_NamedParameter() async {
     String src = '''
 var x = ({/*LINT*/Future<int> defaultValue}) {
   return null;
 };
 ''';
     await findLint(src, LintNames.avoid_types_on_closure_parameters);
 
     await applyFix(DartFixKind.REMOVE_TYPE_NAME);
 
     verifyResult('''
 var x = ({defaultValue}) {
   return null;
 };
 ''');
   }
 
-  test_removeTypeName_avoidTypesOnClosureParameters_NormalParameter() async {
+  test_removeTypeAnnotation_avoidTypesOnClosureParameters_NormalParameter() async {
     String src = '''
 var x = (/*LINT*/Future<int> defaultValue) {
   return null;
 };
 ''';
     await findLint(src, LintNames.avoid_types_on_closure_parameters);
 
     await applyFix(DartFixKind.REMOVE_TYPE_NAME);
 
     verifyResult('''
 var x = (defaultValue) {
   return null;
 };
 ''');
   }
 
-  test_removeTypeName_avoidTypesOnClosureParameters_OptionalParameter() async {
+  test_removeTypeAnnotation_avoidTypesOnClosureParameters_OptionalParameter() async {
     String src = '''
 var x = ([/*LINT*/Future<int> defaultValue]) {
   return null;
 };
 ''';
     await findLint(src, LintNames.avoid_types_on_closure_parameters);
 
     await applyFix(DartFixKind.REMOVE_TYPE_NAME);
 
     verifyResult('''
 var x = ([defaultValue]) {
   return null;
 };
 ''');
   }
 
+  test_removeTypeAnnotation_typeInitFormals_void() async {
+    String src = '''
+class C {
+  int f;
+  C(/*LINT*/int this.f);
+}
+''';
+    await findLint(src, LintNames.type_init_formals);
+
+    await applyFix(DartFixKind.REMOVE_TYPE_NAME);
+
+    verifyResult('''
+class C {
+  int f;
+  C(this.f);
+}
+''');
+  }
+
   test_replaceWithConditionalAssignment_withCodeBeforeAndAfter() async {
     String src = '''
 class Person {
   String _fullName;
   void foo() {
     print('hi');
     /*LINT*/if (_fullName == null) {
       _fullName = getFullUserName(this);
     }
     print('hi');
@@ skipping 323 matching lines @@
   @override
   final AnalysisError error;
 
   _DartFixContextImpl(this.resourceProvider, this.analysisDriver,
       this.astProvider, this.unit, this.error);
 
   @override
   GetTopLevelDeclarations get getTopLevelDeclarations =>
       analysisDriver.getTopLevelNameDeclarations;
 }