Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 3009053002: [vm] Rename "grow_ratio" to "grow_pages" since it is an amount, not a ratio. (Closed)

Created:
3 years, 3 months ago by rmacnak
Modified:
3 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[vm] Rename "grow_ratio" to "grow_pages" since it is an amount, not a ratio. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/a914c24b43a31f733788492124ca05c8403a7017

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M runtime/vm/pages.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 3 months ago (2017-09-01 23:56:54 UTC) #2
siva
lgtm
3 years, 3 months ago (2017-09-02 00:26:17 UTC) #3
rmacnak
3 years, 3 months ago (2017-09-02 00:31:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a914c24b43a31f733788492124ca05c8403a7017 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698