Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1731)

Unified Diff: dashboard/dashboard/pinpoint/elements/job-page-chart.html

Issue 3009023002: [pinpoint] Fix incorrect and missing icons on the chart. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/pinpoint/elements/job-page-chart.html
diff --git a/dashboard/dashboard/pinpoint/elements/job-page-chart.html b/dashboard/dashboard/pinpoint/elements/job-page-chart.html
index b2f98b856dd9b8c7e2e6b15a1408d1addde9927e..d1bb3c62b06343ef9297d3d9679722acb1499b3c 100644
--- a/dashboard/dashboard/pinpoint/elements/job-page-chart.html
+++ b/dashboard/dashboard/pinpoint/elements/job-page-chart.html
@@ -152,7 +152,7 @@ found in the LICENSE file.
this.chart = $.plot(this.$.plot, data, options);
// Draw overlays.
- for (let i = 1; i < valuesByChange.length; ++i) {
+ for (let i = 0; i < valuesByChange.length; ++i) {
const offset = this.chart.pointOffset({
x: i,
y: median(valuesByChange[i]) || (max + min) / 2
@@ -169,7 +169,9 @@ found in the LICENSE file.
// Draw icons for failed and pending attempts.
const status = document.createElement('job-page-chart-icon');
status.setPosition(offset.left, offset.top);
- if (this.jobInfo.comparisons[i] == 'pending') {
+ // TODO: Plumb through real "pending" information from the Job.
+ if (this.jobInfo.comparisons[i] === 'pending' ||
+ this.jobInfo.comparisons[i - 1] === 'pending') {
status.setType('pending');
} else {
status.setType('failed');
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698