Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 3009013002: Allow port and host override in Observatory (Closed)

Created:
3 years, 3 months ago by cbernaschina
Modified:
3 years, 3 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M runtime/observatory/lib/src/repositories/target.dart View 1 1 chunk +14 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
cbernaschina
3 years, 3 months ago (2017-09-01 00:32:46 UTC) #2
rmacnak
lgtm
3 years, 3 months ago (2017-09-01 00:34:00 UTC) #3
cbernaschina
3 years, 3 months ago (2017-09-01 00:37:07 UTC) #4
cbernaschina
3 years, 3 months ago (2017-09-01 00:37:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4ea98fba56f2bbba808c50bfb444ad265b039637 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698