src/x64/lithium-x64.cc - Issue 300893003: Refactor HType to get rid of various hacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-x64.cc

Issue 300893003: Refactor HType to get rid of various hacks. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Skip representation axis in HType::FromType(). Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-x64.cc

diff --git a/src/x64/lithium-x64.cc b/src/x64/lithium-x64.cc

index e1b9e5f159095eccedde4ea3da55f89173e5b131..3989db2580ede5ab19f3fd9496ad022439c337a1 100644

--- a/src/x64/lithium-x64.cc

+++ b/src/x64/lithium-x64.cc

@@ -1918,7 +1918,9 @@ LInstruction* LChunkBuilder::DoChange(HChange* instr) {

LInstruction* LChunkBuilder::DoCheckHeapObject(HCheckHeapObject* instr) {

LOperand* value = UseRegisterAtStart(instr->value());

LInstruction* result = new(zone()) LCheckNonSmi(value);

- if (!instr->value()->IsHeapObject()) result = AssignEnvironment(result);

+ if (!instr->value()->type().IsHeapObject()) {

+ result = AssignEnvironment(result);

+ }

return result;

}