Issue 300893003: Refactor HType to get rid of various hacks.

Issue 300893003: Refactor HType to get rid of various hacks. (Closed)

Created:
6 years, 6 months ago by Benedikt Meurer

Modified:
6 years, 6 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Refactor HType to get rid of various hacks. - Move HType to it's own file. - Add HType::HeapObject and some other useful types. - Get rid of the broken and useless HType::NonPrimitive. - Introduce HType::FromType() to convert from HeapType to HType. - Also add unit tests for HType. - Fix types in Crankshaft. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21578

Patch Set 1 #

Patch Set 2 : Mark test-hydrogen-types with NO_VARIANTS. #

Patch Set 3 : Skip representation axis in HType::FromType(). #

Total comments: 4

Patch Set 4 : REBASE #

Patch Set 5 : Fix compilation. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+460 lines, -254 lines)			Patch
M	src/arm/lithium-arm.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	src/arm64/lithium-arm64.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.cc	View	1 2 3	11 chunks	+14 lines, -26 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		23 chunks	+57 lines, -153 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		5 chunks	+6 lines, -46 lines	0 comments	Download
A	src/hydrogen-types.h	View	1 2 3 4	1 chunk	+87 lines, -0 lines	0 comments	Download
A	src/hydrogen-types.cc	View	1 2	1 chunk	+67 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	test/cctest/cctest.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/cctest.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	test/cctest/test-hydrogen-types.cc	View		1 chunk	+168 lines, -0 lines	0 comments	Download
M	test/cctest/test-types.cc	View	1 2 3	3 chunks	+20 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM, although I'm not sure I can foresee all the implications https://codereview.chromium.org/300893003/diff/40001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): ...

6 years, 6 months ago (2014-05-28 15:21:24 UTC) #2

Benedikt Meurer

https://codereview.chromium.org/300893003/diff/40001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/300893003/diff/40001/src/hydrogen-instructions.h#newcode840 src/hydrogen-instructions.h:840: return !representation().IsSmiOrInteger32() && !representation().IsDouble(); Representation, not type. https://codereview.chromium.org/300893003/diff/40001/src/hydrogen-instructions.h#newcode2775 src/hydrogen-instructions.h:2775: ...

6 years, 6 months ago (2014-05-28 20:03:52 UTC) #3

Benedikt Meurer

6 years, 6 months ago (2014-05-29 04:14:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r21578 (presubmit successful).

Expand Messages | Collapse Messages