Issue 300893002: Rename methods in DocumentThreadableLoader for readability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 300893002: Rename methods in DocumentThreadableLoader for readability (Closed)

Created:
6 years, 6 months ago by tyoshino (SeeGerritForStatus)

Modified:
6 years, 6 months ago

Reviewers:
tkent

CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rename methods in DocumentThreadableLoader for readability Explain what the method actually does preflightSuccess -> loadActualRequest preflightFailure -> handlePreflightFailure BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174947

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -11 lines)			Patch
	M	Source/core/loader/DocumentThreadableLoader.h	View		1 chunk	+6 lines, -3 lines	0 comments	Download
	M	Source/core/loader/DocumentThreadableLoader.cpp	View	1	7 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/300893002/20001

6 years, 6 months ago (2014-05-28 07:33:55 UTC) #3

Message was sent while issue was closed.

Change committed as 174947

Expand Messages | Collapse Messages