Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: runtime/vm/object.cc

Issue 3008923002: Improve the performance of closure-converted code. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index c1cec8022088ff8267b686a9239c247baac77a38..36ca4d6c650f26c3517b31374343341eb34bce04 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -5625,6 +5625,9 @@ const char* Function::KindToCString(RawFunction::Kind kind) {
case RawFunction::kImplicitClosureFunction:
return "ImplicitClosureFunction";
break;
+ case RawFunction::kConvertedClosureFunction:
+ return "ConvertedClosureFunction";
+ break;
case RawFunction::kSignatureFunction:
return "SignatureFunction";
break;
@@ -6352,7 +6355,7 @@ RawFunction* Function::InstantiateSignatureFrom(
if (IsConvertedClosureFunction()) {
sig = Function::NewConvertedClosureFunction(
String::Handle(zone, name()), parent, TokenPosition::kNoSource);
- // TODO(sjindel): Kernel generic methods undone. Handle type parameters
+ // TODO(30455): Kernel generic methods undone. Handle type parameters
// correctly when generic closures are supported. Until then, all type
// parameters to this target are used for captured type variables, so they
// aren't relevant to the type of the function.
« pkg/kernel/lib/transformations/closure/rewriter.dart ('K') | « runtime/vm/kernel_binary_flowgraph.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698