Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Issue 3008893002: Update status for front_end/test/mixin_export_test (Closed)

Created:
3 years, 3 months ago by Dmitry Stefantsov
Modified:
3 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status for front_end/test/mixin_export_test Commit 48503c8720d758a61cc4ceb1281bdd81fbd92e13 introduces test case pkg/front_end/test/mixin_export_test.dart that passes on d8, but doesn't work in browsers. An issue is created for that (dartbug.com/30576). This CL changes the status for the tests on browsers. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/0cf1f7685d17b82fbb8d2993880aa5f672319a98

Patch Set 1 #

Patch Set 2 : Merge updates from "master" (43111261f) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/pkg.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Dmitry Stefantsov
3 years, 3 months ago (2017-08-30 09:44:49 UTC) #2
Johnni Winther
lgtm
3 years, 3 months ago (2017-08-30 09:48:10 UTC) #3
Dmitry Stefantsov
3 years, 3 months ago (2017-08-30 10:01:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0cf1f7685d17b82fbb8d2993880aa5f672319a98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698