Proposed kernel AST changes for annotating parameter type checks.

Proposed kernel AST changes for annotating parameter type checks.

This proposal just describes the API to the AST classes; it does not
introduce any serialization/deserialization code, nor does it try to
represent the annotations in a compact way.

In the final implementation we will probably want to make use of
bitfields; e.g. the new fields VariableDeclaration.formalSafety and
VariableDeclaration.interfaceSafety should probably be replaced with
getters and setters that access bits in VariableDeclaration.flags.

R=dmitryas@google.com

Committed: https://github.com/dart-lang/sdk/commit/1c57563a315cca4f9ff0cde727f6574f546f4309

[Paul Berry, 2017-08-29 22:07:21]

paulberry@google.com changed reviewers:
+ dmitryas@google.com

[Jennifer Messerly, 2017-08-29 23:02:22]

jmesserly@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2017-08-29 23:02:24]

fyi, this looks great to me!

https://codereview.chromium.org/3008853002/diff/1/pkg/kernel/lib/ast.dart
File pkg/kernel/lib/ast.dart (right):

https://codereview.chromium.org/3008853002/diff/1/pkg/kernel/lib/ast.dart#new...
pkg/kernel/lib/ast.dart:3876: ///     class D extends C<num> {
one thing that might be worth an example?

class C<S, T> {
  void f(S x /*semi-typed*/, T y /*semi-typed*/) { ... }
}
class D<T> extends C<num, T> {
  void f(num x /*typed*/, T y /*semi-typed*/) { ... }
}

what's nice is that illustrates that a class like `D` can have some typed and
some semi-typed parameters.

[Paul Berry, 2017-08-29 23:24:24]

https://codereview.chromium.org/3008853002/diff/1/pkg/kernel/lib/ast.dart
File pkg/kernel/lib/ast.dart (right):

https://codereview.chromium.org/3008853002/diff/1/pkg/kernel/lib/ast.dart#new...
pkg/kernel/lib/ast.dart:3876: ///     class D extends C<num> {
On 2017/08/29 23:02:23, Jennifer Messerly wrote:
> one thing that might be worth an example?
> 
> class C<S, T> {
>   void f(S x /*semi-typed*/, T y /*semi-typed*/) { ... }
> }
> class D<T> extends C<num, T> {
>   void f(num x /*typed*/, T y /*semi-typed*/) { ... }
> }
> 
> what's nice is that illustrates that a class like `D` can have some typed and
> some semi-typed parameters.

Good idea.  Done.

[Dmitry Stefantsov, 2017-08-30 10:40:29]

LGTM

[Paul Berry, 2017-08-30 19:51:33]

On 2017/08/30 10:40:29, Dmitry Stefantsov wrote:
> LGTM

Ok, since this change doesn't break anything, and it unblocks my work, I'm going
to land it as is.  I'll follow up with a CL that adds
serialization/deserialization and stores things compactly in bitfields.

[Paul Berry, 2017-08-30 19:52:37]

Description was changed from

==========
Proposed kernel AST changes for annotating parameter type checks.

This proposal just describes the API to the AST classes; it does not
introduce any serialization/deserialization code, nor does it try to
represent the annotations in a compact way.

In the final implementation we will probably want to make use of
bitfields; e.g. the new fields VariableDeclaration.formalSafety and
VariableDeclaration.interfaceSafety should probably be replaced with
getters and setters that access bits in VariableDeclaration.flags.
==========

to

==========
Proposed kernel AST changes for annotating parameter type checks.

This proposal just describes the API to the AST classes; it does not
introduce any serialization/deserialization code, nor does it try to
represent the annotations in a compact way.

In the final implementation we will probably want to make use of
bitfields; e.g. the new fields VariableDeclaration.formalSafety and
VariableDeclaration.interfaceSafety should probably be replaced with
getters and setters that access bits in VariableDeclaration.flags.

R=dmitryas@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1c57563a315cca4f9ff0cde727f6574f546f4309
==========

[Paul Berry, 2017-08-30 19:52:38]

Committed patchset #2 (id:20001) manually as
1c57563a315cca4f9ff0cde727f6574f546f4309 (presubmit successful).